This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Add precision for currency filter #5674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
+1. Please pull this in. Though it seems odd and it is probably rare to want more than 2 decimal places of precision, there are certain business cases where it is actually needed. We ran into one today and our workaround is messy. |
|
Just in case anyone seeing this doesn't know. Angular i18n support doesn't currently support precision for different locales. #5672 fixes this issue and should be pulled asap, to fix this fairly massive bug. |
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jul 27, 2014
It should pass through the currency number pattern from the current locale Closes angular#5674
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jul 27, 2014
It should pass through the currency number pattern from the current locale Closes angular#5674
|
Moved to #8363 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5672.
This adds the fractionSize parameter to the currency filter.
For some, the common fractionSize of 2 needs to be overridden in certain scenarios.
Example: gas pricing in the US where the price is actually accurate to 3 decimal places.