Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Controllers): remove the word 'hides' #15375

Closed
wants to merge 1 commit into from
Closed

docs(guide/Controllers): remove the word 'hides' #15375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/content/guide/controller.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,9 @@ scopes being created for our view:

- The root scope
- The `MainController` scope, which contains `timeOfDay` and `name` properties
- The `ChildController` scope, which inherits the `timeOfDay` property but overrides (hides) the `name`
property from the previous
- The `GrandChildController` scope, which overrides (hides) both the `timeOfDay` property defined in `MainController`
- The `ChildController` scope, which inherits the `timeOfDay` property but overrides the `name`
property from the previous scope
- The `GrandChildController` scope, which overrides both the `timeOfDay` property defined in `MainController`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I like the "hides". It gives a better "feel" of what is going on especially for people not familiar with prototypal inheritance in JS. Leaving "overrides" might give the impression that it changes the value on the parent scope as well.

"Shadows" would be a good alternative for "hides" too, imo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - shadows would be a reasonable compromise.

and the `name` property defined in `ChildController`

Inheritance works with methods in the same way as it does with properties. So in our previous
Expand Down