docs(guide/Controllers): remove the word 'hides' #15375
Conversation
Hiding a property and overriding a property seem to me fundamentally different things. I thought while reading that the '(hides)' did not offer any more clarification than just saying overrides, and caused me to pause unnecessarily to understand it.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it.
|
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
| @@ -253,9 +253,9 @@ scopes being created for our view: | |||
|
|
|||
| - The root scope | |||
| - The `MainController` scope, which contains `timeOfDay` and `name` properties | |||
| - The `ChildController` scope, which inherits the `timeOfDay` property but overrides (hides) the `name` | |||
| property from the previous | |||
| - The `GrandChildController` scope, which overrides (hides) both the `timeOfDay` property defined in `MainController` | |||
There was a problem hiding this comment.
TBH, I like the "hides". It gives a better "feel" of what is going on especially for people not familiar with prototypal inheritance in JS. Leaving "overrides" might give the impression that it changes the value on the parent scope as well.
"Shadows" would be a good alternative for "hides" too, imo.
There was a problem hiding this comment.
I agree - shadows would be a reasonable compromise.
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes #15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes angular#15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes angular#15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes angular#15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes angular#15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes angular#15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes #15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes #15375
"Shadows" should better convey the meaning of "overwriting the value of the property in the child scope, while leaving the parent scope intact". "Hides" could give the impression that it makes the property unavailable in the child scope and leaving "overrides" only, could give the impression that the parent scope would be affected too, especially to people not familiar with JavaScript's prototypal inheritance. Closes angular#15375
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
Hiding a property and overriding a property seem to me fundamentally different things. I thought while reading that the '(hides)' did not offer any more clarification than just saying overrides, and caused me to pause unnecessarily to understand it.