This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): correctly escape unsafe identifier characters #14942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds a couple of tests for `$parseProvider.setIdentifierFns()`.
|
/cc @lgalfaso |
|
LGTM |
| @@ -1260,7 +1261,7 @@ ASTCompiler.prototype = { | |||
| }, | |||
|
|
|||
| nonComputedMember: function(left, right) { | |||
| var SAFE_IDENTIFIER = /[$_a-zA-Z][$_a-zA-Z0-9]*/; | |||
| var SAFE_IDENTIFIER = /^[$_a-zA-Z][$_a-zA-Z0-9]$/; | |||
There was a problem hiding this comment.
Don't we need to keep the *? Otherwise almost everything will use the ['...'] format...
There was a problem hiding this comment.
You are right. I must have accidentally removed it 😇
gkalpak
force-pushed
the
fix-parse-escape-unsafe-identifiers
branch
from
d8658e9 to
4754b21
Compare
gkalpak
added a commit
that referenced
this pull request
Jul 26, 2016
This commit also adds a couple of tests for `$parseProvider.setIdentifierFns()`. Closes #14942
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
While it is possible to use arbitrary identifier characters in Angular expressions, the RegExp that detect unsafe identifiers (in order to escape them in the generated JS code), was failing to detect them in some cases.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
This PR also includes some minor clean-up changes and fixes the
setLiteral()tests to run in CSP mode too.