Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 4754b21

Browse files
committed
fixup! fix($parse): correctly escape unsafe identifier characters
1 parent e2e20c8 commit 4754b21

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/ng/parse.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1261,7 +1261,7 @@ ASTCompiler.prototype = {
12611261
},
12621262

12631263
nonComputedMember: function(left, right) {
1264-
var SAFE_IDENTIFIER = /^[$_a-zA-Z][$_a-zA-Z0-9]$/;
1264+
var SAFE_IDENTIFIER = /^[$_a-zA-Z][$_a-zA-Z0-9]*$/;
12651265
var UNSAFE_CHARACTERS = /[^$_a-zA-Z0-9]/g;
12661266
if (SAFE_IDENTIFIER.test(right)) {
12671267
return left + '.' + right;

test/ng/parseSpec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3909,10 +3909,10 @@ describe('parser', function() {
39093909
beforeEach(module(function($parseProvider) {
39103910
isIdentifierStartFn = jasmine.
39113911
createSpy('isIdentifierStart').
3912-
and.callFake(function (ch, cp) { return isIdentifierStartRe.test(ch); });
3912+
and.callFake(function(ch, cp) { return isIdentifierStartRe.test(ch); });
39133913
isIdentifierContinueFn = jasmine.
39143914
createSpy('isIdentifierContinue').
3915-
and.callFake(function (ch, cp) { return isIdentifierContinueRe.test(ch); });
3915+
and.callFake(function(ch, cp) { return isIdentifierContinueRe.test(ch); });
39163916

39173917
$parseProvider.setIdentifierFns(isIdentifierStartFn, isIdentifierContinueFn);
39183918
csp().noUnsafeEval = cspEnabled;

0 commit comments

Comments
 (0)