docs(guide): add dart version of structural directives #701
Conversation
|
I messed up in the other pull request |
|
It looks like you haven't incorporated all the comments from #696, so I'll wait for another commit before taking a final look. |
|
@kwalrath I removed the unused file and changed to relative imports. |
|
|
||
| // Mock todo: get 10,000 rows of data from the server | ||
| ngOnInit() => _log( | ||
| "heavy-loader ${id} initialized, loading 10,000 rows of data from the server"); |
There was a problem hiding this comment.
Any feedback on this string interpol style yet?
The Dart style guide discourages {} here
There was a problem hiding this comment.
@zoechi Aparently they're only necessary when it is a expression or you're calling a method in a object. I'll remove them. Thanks
|
@sanfordredlich could you please do a technical review? I'm especially curious about the |
| } | ||
|
|
||
| /// Triggers the next round of Angular change detection | ||
| /// after one turn of the JavaScript cycle |
There was a problem hiding this comment.
Is "JavaScript cycle" a good explanation here?
There was a problem hiding this comment.
Good question. How about "browser event loop"? We should perhaps make this change to the JS/TS samples, too.
There was a problem hiding this comment.
Sounds good and should fly in JS land as well
There was a problem hiding this comment.
done, also sent a PR to change it in the TS example.
#710
|
I'm going to merge this PR, so we can point to this code from a placeholder page. We'll do a final technical review before I write & publish the real page. |
No description provided.