docs(guide): add dart version of structural directives #696
Conversation
| dart_to_js_script_rewriter: ^0.1.0 | ||
| transformers: | ||
| - angular2: | ||
| platform_directives: 'package:angular2/src/common/directives.dart#CORE_DIRECTIVES' |
There was a problem hiding this comment.
src/common/directives.dart -> common.dart
|
Good work! I left a bunch of nitty comments, but I think the code is good. I'll ask @sanfordredlich to be the real technical reviewer. |
|
LGTM! I'll wait for a real technical reviewer to have a look before merging this. |
| ngOnInit() { | ||
| // Mock todo: get 10,000 rows of data from the server | ||
| _log( | ||
| "heavy-loader ${id} initialized, loading 10,000 rows of data from the server"); |
There was a problem hiding this comment.
I personally like it this way but the style guide says to omit {} when they are not required
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
@kwalrath