Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore: Angular 1 -> AngularJS / Angular 2 -> Angular #3143

Merged
merged 2 commits into from
Jan 26, 2017

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Jan 26, 2017

@filipesilva or @Foxandxss Please merge as soon as you have reviewed to see that there are no obvious mistakes. We want this for tomorrow.

We still need to make a sweep sample file names #3144

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@Foxandxss Foxandxss merged commit de4903b into angular:master Jan 26, 2017
abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
* chore: Angular 1 -> AngularJS / Angular 2 -> Angular

* Jesus' tweaks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants