This repository was archived by the owner on Dec 4, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 875
docs(guide & api): feedback/issue links for Dart should refer to Dart repos #2821
Merged
kwalrath
merged 5 commits into
angular:master
from
IdeaBlade:chalin-guide-index-dart-feedback-link-1117
Nov 18, 2016
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bee898b
docs(guide/index): feedback link to Dart repo for Dart
chalin 1a1fbb7
docs(api): issue links should refer to Dart repo
chalin 22ad567
post-review updates
chalin 44228b4
add link to Advance and Guide chapters
chalin d66af5d
ensure that we can determine which language is active
chalin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,12 @@ | ||
include ../_util-fns | ||
|
||
:marked | ||
> **Known issues:** The angular.io issue tracker contains [all known | ||
issues][api-issues]; if you notice others, please [report | ||
them][new-issue]. Thanks! | ||
> **Known issues:** The Angular issue tracker contains | ||
[all known issues][api-issues]; if you notice others, please | ||
[report them][new-issue]. Thanks! | ||
|
||
[new-issue]: https://github.com/angular/angular.io/issues/new?labels=dart,api&title=%5BDart%5D%5BAPI%5D%20 | ||
[api-issues]: https://github.com/angular/angular.io/issues?q=label%3Aapi+label%3Adart | ||
[new-issue]: !{_ngRepoURL}/issues/new?title=%5BAPI%20docs%5D | ||
[api-issues]: !{_ngRepoURL}/issues | ||
//- ?q=label%3Aapi | ||
|
||
api-list(src="api-list.json" lang="dart") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little weird to have links on QuickStart but not on Guide & Advanced... But it is definitely handy to have these links, especially for those times when the window is too narrow to display the sidenav.
This is a case where having everything in the guide/ directory is coming back to bite us.
Maybe we should try this out and see if anyone objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I excluded guide, because this page is the link to the Guide. Do you want me to add a self link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think a self-link is helpful. We could maybe briefly mention in the text that that's where they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I was thinking about that, but wasn't sure how to adjust the text.)