docs(guide & api): feedback/issue links for Dart should refer to Dart repos #2821

chalin · 2016-11-17T20:40:18Z

Also added links to chapters mentioned in table.
Other minor copyedits.

kwalrath · 2016-11-17T21:30:41Z

public/docs/ts/latest/guide/index.jade


-  Use the [Angular Github repo](https://github.com/angular/angular) to report issues with **Angular** itself.
+  - Use the [site Github repo](!{_ngDocRepoURL}) for **documentation** issues and pull requests.


Github -> GitHub

(Global. Not introduced in this PR, but while you're there...)

kwalrath · 2016-11-17T21:57:49Z

public/docs/ts/latest/guide/index.jade

@@ -22,7 +21,7 @@ table(width="100%")
  col(width="15%")
  col
  tr(style=top)
-    td <b>QuickStart</b>
+    td <b><a href="../quickstart">QuickStart</a></b>


It's a little weird to have links on QuickStart but not on Guide & Advanced... But it is definitely handy to have these links, especially for those times when the window is too narrow to display the sidenav.

This is a case where having everything in the guide/ directory is coming back to bite us.

Maybe we should try this out and see if anyone objects?

I excluded guide, because this page is the link to the Guide. Do you want me to add a self link?

This is a case where having everything in the guide/ directory is coming back to bite us.
Yes.

Maybe we should try this out and see if anyone objects?
Agreed.

No, I don't think a self-link is helpful. We could maybe briefly mention in the text that that's where they are.

(I was thinking about that, but wasn't sure how to adjust the text.)

kwalrath · 2016-11-17T22:01:18Z

public/docs/dart/latest/api/index.jade

@@ -1,9 +1,12 @@
+include ../_util-fns
+
 :marked
  > **Known issues:** The angular.io issue tracker contains [all known


angular.io -> Angular

- Also added links to chapters mentioned in table. - Other minor copyedits.

kwalrath

Looks great!

commit 7c8938a Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Fri Nov 18 07:53:41 2016 -0800 example(pipes): Dart e2e fix (angular#2825) Match TS example and only bootstrap AppComponent. commit 1c2d14a Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Thu Nov 17 16:53:28 2016 -0800 docs(guide & api): feedback/issue links for Dart should refer to Dart repos (angular#2821) * docs(guide/index): feedback link to Dart repo for Dart - Also added links to chapters mentioned in table. - Other minor copyedits. * docs(api): issue links should refer to Dart repo * post-review updates * add link to Advance and Guide chapters * ensure that we can determine which language is active commit e59cd9a Author: Eric Jimenez <eric.jimenez.dev@gmail.com> Date: Thu Nov 17 18:02:32 2016 -0500 chore: remove deprecated `clear=` and use clear layout helpers (angular#2822) * define clear layout helpers * replace deprecated clear= with helper commit bde8fe1 Author: Eric Jimenez <eric.jimenez.dev@gmail.com> Date: Thu Nov 17 17:54:42 2016 -0500 remove grid fluid from dart api list (angular#2823) commit f993315 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Thu Nov 17 14:10:28 2016 -0800 chore(dart): complete the renaming of "Angular 2" to "Angular" (angular#2820) Contributes to angular#2407 - Dropped the “2” in “Angular 2” and “angular2_*” where appropriate. - Did a partial sync of `_cache/guide/pipes.jade` - In quickstart, changed `Try changing the message to "Hello Angular 2!”` to `Try changing the message to "Hello Again Angular!”`. commit d853a29 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Thu Nov 17 13:47:51 2016 -0800 examples(dart): demote some packages to dev_dependencies (angular#2818) Fixes angular#2777 commit 7febba6 Author: Kenny John Jacob <johnjacobkenny@gmail.com> Date: Fri Nov 18 02:24:55 2016 +0530 docs(router): fix missing anchor id (angular#2817) The link *Importing from the router library* (https://angular.io/docs/ts/latest/guide/router.html#import) does not work. I supposed that this was the corresponding section to be linked to. commit 2a3dbe5 Author: Eric Jimenez <eric.jimenez.dev@gmail.com> Date: Thu Nov 17 12:37:14 2016 -0500 replace clearfix with a wrapping flexbox (angular#2819) commit 061e50f Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Wed Nov 16 10:02:31 2016 -0800 docs: adjust page heading levels (angular#2813) * docs: adjust page heading levels Only the page TOC should be at heading level 1. All other headings should start at level 2. This commit also removes duplicate headings, in continuation of angular#2796. (This fix is necessary to support an auto-TOC feature.) commit 31e0101 Author: Filipe Silva <filipematossilva@gmail.com> Date: Wed Nov 16 17:51:06 2016 +0000 fix(live-example): correctly match example name (angular#2815) Currently, when visiting a page with a relative link e.g. https://angular.io/docs/ts/latest/guide/testing.html#!#top, `NgIoUtil.getExampleName` fails to match the example name. This results on `live-example` directives on that page missing the example name in the link: instead of linking to https://angular.io/resources/live-examples/testing/ts/plnkr.html it will link to https://angular.io/resources/live-examples//ts/plnkr.html (notice the missing `testing` and the double slashes). commit e0aecb3 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 15 15:38:02 2016 -0800 docs(struct-directives): update Dart cache (angular#2806) Only minor prose edits in this PR. No net change in the generated HTML for the TS side. commit 0dfda08 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 15 15:36:34 2016 -0800 docs: in links use href=foo#bar not foo#!#bar (angular#2807) commit 64bce18 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 15 14:58:56 2016 -0800 e2e(dependency-injection): fix for Dart and simplification for TS Fixes angular#2493 No need to dual boot `AppComponent` and `ProvidersComponent` only to ensure that we could demo optional injection; instead just inject null for the `@Optional` constructor parameter type. No prose is affected by these changes. commit 4a4144e Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 15 14:55:33 2016 -0800 docs(tutorial): update Dart cache for toh intro (angular#2805) commit f70ba97 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 15 08:39:03 2016 -0800 example(architecture/dart): drop currency pipe workaround (angular#2804) Fixes angular#1898

chalin assigned kwalrath Nov 17, 2016

googlebot added the CLA: yes label Nov 17, 2016

chalin force-pushed the chalin-guide-index-dart-feedback-link-1117 branch from 3d948c1 to dfe5d34 Compare November 17, 2016 21:03

chalin changed the title ~~docs(guide/index): feedback link to Dart repo for Dart~~ docs(guide & api): feedback/issue links for Dart should refer to Dart repos Nov 17, 2016

kwalrath reviewed Nov 17, 2016

View reviewed changes

chalin force-pushed the chalin-guide-index-dart-feedback-link-1117 branch from dfe5d34 to f0496b9 Compare November 17, 2016 22:18

chalin added 4 commits November 17, 2016 15:05

docs(guide/index): feedback link to Dart repo for Dart

bee898b

- Also added links to chapters mentioned in table. - Other minor copyedits.

docs(api): issue links should refer to Dart repo

1a1fbb7

post-review updates

22ad567

add link to Advance and Guide chapters

44228b4

chalin force-pushed the chalin-guide-index-dart-feedback-link-1117 branch from f0496b9 to 44228b4 Compare November 17, 2016 23:06

kwalrath approved these changes Nov 17, 2016

View reviewed changes

ensure that we can determine which language is active

d66af5d

kwalrath merged commit 1c2d14a into angular:master Nov 18, 2016

kwalrath deleted the chalin-guide-index-dart-feedback-link-1117 branch November 18, 2016 00:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs(guide & api): feedback/issue links for Dart should refer to Dart repos #2821

docs(guide & api): feedback/issue links for Dart should refer to Dart repos #2821

Uh oh!

chalin commented Nov 17, 2016

Uh oh!

kwalrath Nov 17, 2016

Uh oh!

chalin Nov 17, 2016

Uh oh!

kwalrath Nov 17, 2016

Uh oh!

chalin Nov 17, 2016

Uh oh!

kwalrath Nov 17, 2016

Uh oh!

chalin Nov 17, 2016

Uh oh!

kwalrath Nov 17, 2016

Uh oh!

chalin Nov 17, 2016

Uh oh!

kwalrath left a comment

Uh oh!

Uh oh!


		Use the [Angular Github repo](https://github.com/angular/angular) to report issues with Angular itself.
		- Use the [site Github repo](!{_ngDocRepoURL}) for documentation issues and pull requests.

docs(guide & api): feedback/issue links for Dart should refer to Dart repos #2821

docs(guide & api): feedback/issue links for Dart should refer to Dart repos #2821

Uh oh!

Conversation

chalin commented Nov 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kwalrath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!