Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(toh-5): dashboard uses [routerLink] bindings #998 #2718

Merged
merged 2 commits into from
Nov 3, 2016

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Nov 1, 2016

Per issue #998, switch from imperative routing to anchors with [routerLink] bindings in the DashboardComponent.

Kept the button-click imperative navigation in HeroesComponent mainly to show how to do that when you need imperative navigation but also because this use case is more button-like than anchor-like.

@chalin Modified the DART example to match. I think I did it right but would be great if you confirmed.

@wardbell wardbell force-pushed the docs-toh-dashboard-router-links branch from 7323ff7 to 16d6ed8 Compare November 3, 2016 06:55
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added CLA: no and removed CLA: yes labels Nov 3, 2016
@chalin
Copy link
Contributor

chalin commented Nov 3, 2016

googlebot, you are mistaken, I did author the commit.

On Thu, Nov 3, 2016 at 9:11 AM, googlebot notifications@github.com wrote:

We found a Contributor License Agreement for you (the sender of this pull
request) and all commit authors, but as best as we can tell these commits
were authored by someone else. If that's the case, please add them to this
pull request and have them confirm that they're okay with these commits
being contributed to Google. If we're mistaken and you did author these
commits, just reply here to confirm.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2718 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD8u-Z74CkeAsrjF9w1eRdKsURH9bdh7ks5q6geWgaJpZM4Kl5_L
.

@chalin
Copy link
Contributor

chalin commented Nov 3, 2016

I did author the commits. Googlebot!

@wardbell
Copy link
Contributor Author

wardbell commented Nov 3, 2016

Thanks, @chalin. Merging. You'll come back latter with the Dart fixes and remove the entry from bad-code-excerpt-skip-patterns.txt.

@wardbell wardbell merged commit fa99a8b into angular:master Nov 3, 2016
@wardbell wardbell deleted the docs-toh-dashboard-router-links branch November 3, 2016 17:25
@chalin
Copy link
Contributor

chalin commented Nov 3, 2016

Follow-up is #2744.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants