docs(router): Updated usage of observables in tutorial and dev guide #2696

brandonroberts · 2016-10-30T04:09:03Z

Updated usage of observable route parameters and updated prose
Moved route configurations into separate variable for consistency
Added async pipe to handle subscriptions for list items
Removed old routing files

cc: @wardbell @robwormald

wardbell

I've left a few suggested changes in my notes.

I am NOT happy with the switchMap business.

It adds complexity (more RxJs madness) and it seems like overkill to account for a condition that cannot actually happen in either the Router app or the ToH app. There is no way the user can navigate to the same component instance with a different id.

I know Rob wants it. Let's see if people freak out. I'm prepared to reverse this if they do and fall back to subscribe ... which worked just fine.

wardbell · 2016-10-31T06:10:29Z

public/docs/_examples/router/ts/app/crisis-center/crisis-detail.component.1.ts

-            }
-          });
+    this.route.params
+      .switchMap((params: Params) => this.service.getCrisis(+params['id']))


the + in front of params is not needed because the CrisisService.getCrisis converts the string id

The CrisisService.getCrisis returns a promise. Are you saying that switchMap handles that as if the service method returned an observable? [A: apparently yes ... says the discussion of switchMap in the prose.]

And why is switchMap needed at all? What was wrong with the original code, assuming we replace forEach with subscribe. This version is longer with more parts (the switchMap import and usage). To what purpose?

As I understand it from the new prose (which I did not see when I made this comment), the switchMap has the ability to cancel an in-flight request. That's useful if (a) the user can re-navigate to this component instance with a different id and (b) the previous request could somehow arrive after a new request returned. (a) is not possible in this app and (b) is highly unlikely. But ... at least I understand the intention.

I guess I'll let it go ... for now. I'm removing my objections to switchMap here and elsewhere in this PR.

wardbell · 2016-10-31T06:29:46Z

public/docs/_examples/toh-5/ts/app/dashboard.component.ts

@@ -33,7 +33,7 @@ export class DashboardComponent implements OnInit {

  ngOnInit(): void {
    this.heroService.getHeroes()
-      .then(heroes => this.heroes = heroes.slice(1, 5));
+      .then((heroes: Hero[]) => this.heroes = heroes.slice(1, 5));


Why? What's wrong with type inference?

My editor was giving me type errors. I thought something changed with the linting. I'll leave it as-is

wardbell · 2016-10-31T06:29:59Z

public/docs/_examples/toh-5/ts/app/dashboard.component.2.ts

@@ -20,7 +20,7 @@ export class DashboardComponent implements OnInit {

  ngOnInit(): void {
    this.heroService.getHeroes()
-      .then(heroes => this.heroes = heroes.slice(1, 5));
+      .then((heroes: Hero[]) => this.heroes = heroes.slice(1, 5));


Why? What's wrong with type inference?

wardbell · 2016-10-31T06:32:13Z

public/docs/_examples/toh-5/ts/app/hero-detail.component.1.ts

@@ -4,6 +4,7 @@

 // #docregion added-imports
 // Keep the Input import for now, we'll remove it later:
+import 'rxjs/add/operator/switchMap';


Why? The imported switchMap is not used? Nor is it mentioned in the accompanying text.

wardbell · 2016-10-31T06:33:47Z

public/docs/_examples/toh-5/ts/app/heroes.component.ts

@@ -29,7 +29,7 @@ export class HeroesComponent implements OnInit {
    private heroService: HeroService) { }

  getHeroes(): void {
-    this.heroService.getHeroes().then(heroes => this.heroes = heroes);
+    this.heroService.getHeroes().then((heroes: Hero[]) => this.heroes = heroes);


Why? Don't do this. Let type inference do its thing.

wardbell · 2016-10-31T06:47:02Z

public/docs/ts/latest/guide/router.jade

+    an `Observable` as well as a `Promise` to retrieve the value they emit.
+
+    We could have used the `flatMap` operator, which works the same way with one exception.
+    The `switchMap` operator will also cancel any in-flight requests if our user re-navigates to the route


Is this the justification for switchMap? I guess it makes some sense even though this app doesn't support direct re-navigation to the route and the service doesn't support canceling a request. Maybe these will be capabilities some day.

Meanwhile, we're introducing something that our reader is not prepared to understand.

Why is this important here when we are trying to teach routing? It feels like it makes routing seem even more complicated.

Upon further reflection, while I remain profoundly uncomfortable with what seems like a distraction to me, I'm letting it slide.

wardbell · 2016-10-31T06:50:24Z

public/docs/ts/latest/guide/router.jade

@@ -1096,8 +1112,14 @@ code-example(language="bash").
 +makeExcerpt('app/heroes/hero-list.component.ts (import)', 'import-router')

 :marked
+  We'll import the `switchMap` operator to perform operations on our `Observable`


"to perform operations"? It can only perform ONE operation, right? If we say anything it might be

We import the switchMap operator because we need it later to process the Observable route parameters.

wardbell · 2016-10-31T07:14:44Z

public/docs/ts/latest/guide/router.jade

+
+makeExcerpt('app/heroes/hero-list.component.ts (rxjs imports)', 'rxjs-imports')
+
+:marked
  Then we use the `ActivatedRoute` to access the `params` _Observable_ so we can subscribe


This sentence (which I probably wrote originally) needs to be reworked. Too wooden, too complicated.

Try:
...
Then we inject the ActivatedRoute in the HeroListComponent constructor.

[show the code snippet]

The ActivatedRoute.params property is an Observable of route parameters. The params emits new id values when the user navigates to the component. In ngOnInit we subscribe to those values, set the selectedId, and get the heroes.
...
Also re-title the code snippet which purports to be about the constructor but is actually about both the constructor and the ngOnInit.

wardbell · 2016-10-31T07:17:40Z

public/docs/ts/latest/tutorial/toh-pt5.jade


 - var _str2int = _docsFor == 'dart' ? '<code>int.parse</code> static method' : 'JavaScript (+) operator'
 :marked
  The hero `id` is a number. Route parameters are *always strings*.
  So we convert the route parameter value to a number with the !{_str2int}.

+.l-sub-section
+  :marked
+    ### Do I need to unsubscribe?


Thanks for adding this.

wardbell · 2016-10-31T07:27:08Z

public/docs/ts/latest/tutorial/toh-pt5.jade

@@ -530,14 +530,27 @@ block ngOnInit

 block extract-id
  :marked
-    Notice how we extract the `id` by calling the `forEach` method
-    which will deliver our !{_array} of route parameters.
+    Notice how we use the `switchMap` operator on the `Observable` to


I wonder why the original said there is an array of route parameters. There is a params object and the +params['id'] expression gets the id parameter from that object. Weird.

Rewrite
...
Note how the switchMap operator maps the id in the observable route parameters
to a new Observable, the result of the HeroService.getHero method.

If the user re-navigates to this component while a getHero request is still inflight,
switchMap cancels that old request before calling HeroService.getHero again.
...

brandonroberts · 2016-11-02T02:37:08Z

@wardbell I made the suggested changes to the prose for the usage of switchMap and other concerns.

wardbell · 2016-11-02T22:45:46Z

Excellent. Will merge right after #2718 with Igor's suggestion. Want to make sure no merge conflicts.

…eloper guide Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items

wardbell · 2016-11-14T19:14:15Z

Resolved merge conflicts (all in toh-pt5.jade) since the last review. Merging as soon as it clears Travis

@Foxandxss

commit 17c7e15 Author: Filipe Silva <filipematossilva@gmail.com> Date: Mon Nov 14 23:11:37 2016 +0000 chore: update to 2.2.0 (angular#2797) commit 1e5facf Merge: 5c4cc9a db0fac9 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 12:44:51 2016 -0800 Merge pull request angular#2799 from IdeaBlade/docs-changelog-2.2.0 chore(changelog): update docs changelog for Ng v.2.2.0 commit 5c4cc9a Merge: 43457e9 1afe5dc Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 12:43:09 2016 -0800 docs(router): Updated usage of observables in router tutorial and developer guide (angular#2696) Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit 43457e9 Merge: a423a5a 2649647 Author: Jesús Rodríguez <Foxandxss@gmail.com> Date: Mon Nov 14 21:38:49 2016 +0100 chore: add upgrade/static to API reference (angular#2755) commit 1afe5dc Author: Brandon Roberts <robertsbt@gmail.com> Date: Sat Oct 29 16:08:54 2016 -0500 docs(router): Updated usage of observables in router tutorial and developer guide Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit db0fac9 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 10:48:09 2016 -0800 chore(changelog): update docs changelog for Ng v.2.2.0 commit a423a5a Author: ikilled <ikilled@users.noreply.github.com> Date: Mon Nov 14 18:39:46 2016 +0000 clicking on Books & Training sends user to Education (angular#2701) When user clicks in Books & Training item in footer the website should take them to Education section (anchor) in the middle of the page, not to the top where Development section is. commit d63b1cc Merge: f627706 8508140 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 10:35:48 2016 -0800 docs(router): fixed verbiage about router-outlet (angular#2746) commit f627706 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 10:26:13 2016 -0800 docs(cookbook-aot-compiler): improve Ahead-of-Time compilation cookbook (angular#2798) closes angular#2790 commit 75464d5 Merge: 78e2584 02f5559 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 09:34:36 2016 -0800 Merge pull request angular#2794 from IdeaBlade/chalin-guide-misc-fix-1113 docs: guide/index misc Jade fixes commit 78e2584 Merge: 182493f 85062c4 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 09:33:55 2016 -0800 Merge pull request angular#2795 from IdeaBlade/chalin-util-js-getExampleName-1114 chore(util.js): getExampleName - support optional .html suffix commit 182493f Merge: 9e9666b 53f5538 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 09:28:40 2016 -0800 feat(cb-ts-to-js): add es6 examples (angular#2606) * feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar * docs(ts-to-js): ward's edits (incomplete) * docs(ts-to-js): add separate template files for some components * docs(cb-ts-to-js): refactor sample code commit 53f5538 Author: Ward Bell <wardbell@hotmail.com> Date: Sun Nov 13 14:09:28 2016 -0800 docs(cb-ts-to-js): refactor sample code commit 9e9666b Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Mon Nov 14 08:34:10 2016 -0800 docs(template-syntax/dart): updates to match TS (angular#2751) * docs(template-syntax): refresh _cache * docs(template-syntax/dart): updates to match TS - Propagates TS-side changes: - update angular#2639 - new two-way binding section, and - fix angular#2687 - invalid attr syntax - Fixes - angular#1898 - currency symbols - angular#2748 - Dart template-syntax e2e is failing - angular#2749 - deprecated `[className]` * updated _cache file following Kathy's post-review edits * Post Ward's review w/ cache updated - Keep `my-` and `my` prefixes on selectors (for components and directives, respectively). - Drop `my-` from file names. - Drop `My` as component class prefix. commit 5dcffd6 Author: Patrice Chalin <pchalin@gmail.com> Date: Sun Nov 13 19:37:13 2016 -0800 docs: dart glossary - fix misnamed Jade block commit 6680acc Merge: 14db838 3b03573 Author: Kathy Walrath <kathyw@google.com> Date: Mon Nov 14 08:31:11 2016 -0800 docs(toh): avoid dup header title (angular#2796) * remove redundant headings * update _cache * misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 3b03573 Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 05:30:05 2016 -0800 misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 470426d Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 05:25:36 2016 -0800 update _cache commit c12d75a Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 05:23:35 2016 -0800 remove redundant headings commit 85062c4 Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 04:56:12 2016 -0800 chore(util.js): getExampleName - support optional .html suffix commit 02f5559 Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 04:29:17 2016 -0800 docs: guide/index misc Jade fixes - Eliminate use of deprecated `clear=“all”` in `<br>`. - No need for local `langName`; use global `_Lang` var instead. - Remove duplicate id `learning-path`. commit 14db838 Author: Naomi Black <naomitraveller@gmail.com> Date: Sun Nov 13 21:48:52 2016 -0500 news(nov): Some news and a blog post update commit eff32ec Author: Naomi Black <naomitraveller@gmail.com> Date: Sun Nov 13 21:48:37 2016 -0500 chore(bios): update some bios for leads commit 3ee36fb Author: koyner <markburrett@gmail.com> Date: Sun Nov 13 22:59:59 2016 +0100 docs(forms): grammar fix (angular#2764) commit b11438f Author: Ward Bell <wardbell@hotmail.com> Date: Fri Nov 11 19:44:00 2016 -0800 docs(ts-to-js): add separate template files for some components commit 33b6197 Author: Ward Bell <wardbell@hotmail.com> Date: Thu Nov 3 01:37:55 2016 -0700 docs(ts-to-js): ward's edits (incomplete) commit 12eb19f Author: Filipe Silva <filipematossilva@gmail.com> Date: Thu Oct 13 17:59:00 2016 +0100 feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar commit 64a8754 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Thu Nov 10 20:01:36 2016 -0800 example(template-syntax): follow style-guide and other updates (angular#2750) commit 7619cdf Author: Jesús Rodríguez <Foxandxss@gmail.com> Date: Thu Nov 10 23:47:30 2016 +0100 chore: ability to open a plunker on a specific file (angular#2778) commit 0161d9d Author: Filipe Silva <filipematossilva@gmail.com> Date: Thu Nov 10 22:45:22 2016 +0000 chore: ignore debug.log file (angular#2785) This file is generated when running `gulp e2e` and often enough committed by mistake. /cc @Foxandxss commit f92983c Author: Jesús Rodríguez <Foxandxss@gmail.com> Date: Thu Nov 10 23:44:51 2016 +0100 docs(ngmodule): fix plunkers (angular#2786) commit 03db4bb Author: Martin Eckardt <m.eckardt@outlook.com> Date: Wed Nov 9 17:43:40 2016 +0100 docs(a1-a2): fix link to Filter/Pipes (angular#2770) commit 60565a5 Author: Pavol Pitonak <pavol@pitonak.com> Date: Wed Nov 9 17:42:57 2016 +0100 docs(testing): configureTestModule -> configureTestingModule (angular#2767) commit ec47197 Author: Catalin Zalog <xxxxxcata@yahoo.com> Date: Wed Nov 9 18:41:56 2016 +0200 docs(style-guide): fix missing *.ts (angular#2763) commit 234e468 Author: Patrice Chalin <pchalin@gmail.com> Date: Tue Nov 8 08:21:02 2016 -0800 docs: intra-site links should be relative Contributes to angular#2772. commit 6b37da7 Author: Patrice Chalin <pchalin@gmail.com> Date: Tue Nov 8 09:27:10 2016 -0800 docs(forms/dart): remove mention of FORM_DIRECTIVES Fixes angular#2752 commit c24dd07 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 8 14:48:03 2016 -0800 docs(toh-5/dart): use routerLink in dashboard (angular#2744) * docs(toh-5/dart): use routerLink in dashboard * minor edits to TS jade * remove dart/toh-pt5 from bad-code-excerpt-skip-patterns commit 2808878 Author: Patrice Chalin <pchalin@gmail.com> Date: Tue Nov 8 07:41:27 2016 -0800 chore(deploy): don't name project in firebase deploy Naming the project would sometimes cause gulp to report `An unexpected error has occurred` with exit code 2. commit 2649647 Author: Jesus Rodriguez <Foxandxss@gmail.com> Date: Sat Nov 5 00:37:47 2016 +0100 chore: add upgrade/static to API reference commit 8508140 Merge: 37f93bc b1c2c27 Author: Adrian Irwin <mr.irwin@gmail.com> Date: Thu Nov 3 17:27:43 2016 -0700 Merge branch 'router' of https://github.com/adrianirwin/angular.io into router commit 37f93bc Author: Adrian Irwin <mr.irwin@gmail.com> Date: Thu Nov 3 17:25:55 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet commit b1c2c27 Author: Adrian Irwin <adrianirwin@kpmg.com> Date: Thu Nov 3 16:57:56 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet

@Foxandxss

* re-enable upgrade-adapter and upgrade-phonecat-1 tests * re-enable upgrade-phonecat-2 tests * add hybrid toggle switch to helpers * use 2.2.0-rc.0 * revert change to browser.ignoreSynchronization * convert 1-2-hybrid-bootstrap to upgrade/static * remove shared adapter example * add systemjs config extras to all indexes * update upgrade-static * update upgrade-io example * update downgrade-static * update downgrade-io * update 1-to-2-projection * update 2-to-1-transclusion * update 1-to-2-providers * update 2-to-1-providers * cleanup upgrade-adapter e2e test * re-enable upgrade-adapter tests * change HeroDetailComponent to HeroDetailDirective * fix missing systemjs.config.extras * add typing to UpgradeModule DI * update upgrade-phonecat-2-hybrid * update upgrade-adapter's prose * rename upgrade-adapter example to upgrade-module * improve angular1 type declaration in hybrid apps * remove unused imports in protractor-helpers * update phonecat-hybrid bootstrap prose * update phonecat-hybrid service and components * update phonecat-final prose * update e2e prose * update systemjs.config.js to have @angular/upgrade/static by default * add aot (WIP) * remove wip aot changes from test run * change let to const in bootstrap * elaborate upgraded component alert * use 2.2.0 versions instead of rc0 * Squashed commit of the following: commit 17c7e15 Author: Filipe Silva <filipematossilva@gmail.com> Date: Mon Nov 14 23:11:37 2016 +0000 chore: update to 2.2.0 (#2797) commit 1e5facf Merge: 5c4cc9a db0fac9 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 12:44:51 2016 -0800 Merge pull request #2799 from IdeaBlade/docs-changelog-2.2.0 chore(changelog): update docs changelog for Ng v.2.2.0 commit 5c4cc9a Merge: 43457e9 1afe5dc Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 12:43:09 2016 -0800 docs(router): Updated usage of observables in router tutorial and developer guide (#2696) Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit 43457e9 Merge: a423a5a 2649647 Author: Jesús Rodríguez <Foxandxss@gmail.com> Date: Mon Nov 14 21:38:49 2016 +0100 chore: add upgrade/static to API reference (#2755) commit 1afe5dc Author: Brandon Roberts <robertsbt@gmail.com> Date: Sat Oct 29 16:08:54 2016 -0500 docs(router): Updated usage of observables in router tutorial and developer guide Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items commit db0fac9 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 10:48:09 2016 -0800 chore(changelog): update docs changelog for Ng v.2.2.0 commit a423a5a Author: ikilled <ikilled@users.noreply.github.com> Date: Mon Nov 14 18:39:46 2016 +0000 clicking on Books & Training sends user to Education (#2701) When user clicks in Books & Training item in footer the website should take them to Education section (anchor) in the middle of the page, not to the top where Development section is. commit d63b1cc Merge: f627706 8508140 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 10:35:48 2016 -0800 docs(router): fixed verbiage about router-outlet (#2746) commit f627706 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 10:26:13 2016 -0800 docs(cookbook-aot-compiler): improve Ahead-of-Time compilation cookbook (#2798) closes #2790 commit 75464d5 Merge: 78e2584 02f5559 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 09:34:36 2016 -0800 Merge pull request #2794 from IdeaBlade/chalin-guide-misc-fix-1113 docs: guide/index misc Jade fixes commit 78e2584 Merge: 182493f 85062c4 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 09:33:55 2016 -0800 Merge pull request #2795 from IdeaBlade/chalin-util-js-getExampleName-1114 chore(util.js): getExampleName - support optional .html suffix commit 182493f Merge: 9e9666b 53f5538 Author: Ward Bell <wardbell@hotmail.com> Date: Mon Nov 14 09:28:40 2016 -0800 feat(cb-ts-to-js): add es6 examples (#2606) * feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar * docs(ts-to-js): ward's edits (incomplete) * docs(ts-to-js): add separate template files for some components * docs(cb-ts-to-js): refactor sample code commit 53f5538 Author: Ward Bell <wardbell@hotmail.com> Date: Sun Nov 13 14:09:28 2016 -0800 docs(cb-ts-to-js): refactor sample code commit 9e9666b Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Mon Nov 14 08:34:10 2016 -0800 docs(template-syntax/dart): updates to match TS (#2751) * docs(template-syntax): refresh _cache * docs(template-syntax/dart): updates to match TS - Propagates TS-side changes: - update #2639 - new two-way binding section, and - fix #2687 - invalid attr syntax - Fixes - #1898 - currency symbols - #2748 - Dart template-syntax e2e is failing - #2749 - deprecated `[className]` * updated _cache file following Kathy's post-review edits * Post Ward's review w/ cache updated - Keep `my-` and `my` prefixes on selectors (for components and directives, respectively). - Drop `my-` from file names. - Drop `My` as component class prefix. commit 5dcffd6 Author: Patrice Chalin <pchalin@gmail.com> Date: Sun Nov 13 19:37:13 2016 -0800 docs: dart glossary - fix misnamed Jade block commit 6680acc Merge: 14db838 3b03573 Author: Kathy Walrath <kathyw@google.com> Date: Mon Nov 14 08:31:11 2016 -0800 docs(toh): avoid dup header title (#2796) * remove redundant headings * update _cache * misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 3b03573 Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 05:30:05 2016 -0800 misc: make block comment a Jade comment (This prevents the text from appearing in the generated HTML as an HTML comment.) commit 470426d Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 05:25:36 2016 -0800 update _cache commit c12d75a Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 05:23:35 2016 -0800 remove redundant headings commit 85062c4 Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 04:56:12 2016 -0800 chore(util.js): getExampleName - support optional .html suffix commit 02f5559 Author: Patrice Chalin <pchalin@gmail.com> Date: Mon Nov 14 04:29:17 2016 -0800 docs: guide/index misc Jade fixes - Eliminate use of deprecated `clear=“all”` in `<br>`. - No need for local `langName`; use global `_Lang` var instead. - Remove duplicate id `learning-path`. commit 14db838 Author: Naomi Black <naomitraveller@gmail.com> Date: Sun Nov 13 21:48:52 2016 -0500 news(nov): Some news and a blog post update commit eff32ec Author: Naomi Black <naomitraveller@gmail.com> Date: Sun Nov 13 21:48:37 2016 -0500 chore(bios): update some bios for leads commit 3ee36fb Author: koyner <markburrett@gmail.com> Date: Sun Nov 13 22:59:59 2016 +0100 docs(forms): grammar fix (#2764) commit b11438f Author: Ward Bell <wardbell@hotmail.com> Date: Fri Nov 11 19:44:00 2016 -0800 docs(ts-to-js): add separate template files for some components commit 33b6197 Author: Ward Bell <wardbell@hotmail.com> Date: Thu Nov 3 01:37:55 2016 -0700 docs(ts-to-js): ward's edits (incomplete) commit 12eb19f Author: Filipe Silva <filipematossilva@gmail.com> Date: Thu Oct 13 17:59:00 2016 +0100 feat(cb-ts-to-js): add es6 examples update docshredder to shred .es6 optimized focus gulp task convert imports and metadate sections add DI section add host and query metadata section add intro fix capitalization and grammar commit 64a8754 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Thu Nov 10 20:01:36 2016 -0800 example(template-syntax): follow style-guide and other updates (#2750) commit 7619cdf Author: Jesús Rodríguez <Foxandxss@gmail.com> Date: Thu Nov 10 23:47:30 2016 +0100 chore: ability to open a plunker on a specific file (#2778) commit 0161d9d Author: Filipe Silva <filipematossilva@gmail.com> Date: Thu Nov 10 22:45:22 2016 +0000 chore: ignore debug.log file (#2785) This file is generated when running `gulp e2e` and often enough committed by mistake. /cc @Foxandxss commit f92983c Author: Jesús Rodríguez <Foxandxss@gmail.com> Date: Thu Nov 10 23:44:51 2016 +0100 docs(ngmodule): fix plunkers (#2786) commit 03db4bb Author: Martin Eckardt <m.eckardt@outlook.com> Date: Wed Nov 9 17:43:40 2016 +0100 docs(a1-a2): fix link to Filter/Pipes (#2770) commit 60565a5 Author: Pavol Pitonak <pavol@pitonak.com> Date: Wed Nov 9 17:42:57 2016 +0100 docs(testing): configureTestModule -> configureTestingModule (#2767) commit ec47197 Author: Catalin Zalog <xxxxxcata@yahoo.com> Date: Wed Nov 9 18:41:56 2016 +0200 docs(style-guide): fix missing *.ts (#2763) commit 234e468 Author: Patrice Chalin <pchalin@gmail.com> Date: Tue Nov 8 08:21:02 2016 -0800 docs: intra-site links should be relative Contributes to #2772. commit 6b37da7 Author: Patrice Chalin <pchalin@gmail.com> Date: Tue Nov 8 09:27:10 2016 -0800 docs(forms/dart): remove mention of FORM_DIRECTIVES Fixes #2752 commit c24dd07 Author: Patrice Chalin <chalin@users.noreply.github.com> Date: Tue Nov 8 14:48:03 2016 -0800 docs(toh-5/dart): use routerLink in dashboard (#2744) * docs(toh-5/dart): use routerLink in dashboard * minor edits to TS jade * remove dart/toh-pt5 from bad-code-excerpt-skip-patterns commit 2808878 Author: Patrice Chalin <pchalin@gmail.com> Date: Tue Nov 8 07:41:27 2016 -0800 chore(deploy): don't name project in firebase deploy Naming the project would sometimes cause gulp to report `An unexpected error has occurred` with exit code 2. commit 2649647 Author: Jesus Rodriguez <Foxandxss@gmail.com> Date: Sat Nov 5 00:37:47 2016 +0100 chore: add upgrade/static to API reference commit 8508140 Merge: 37f93bc b1c2c27 Author: Adrian Irwin <mr.irwin@gmail.com> Date: Thu Nov 3 17:27:43 2016 -0700 Merge branch 'router' of https://github.com/adrianirwin/angular.io into router commit 37f93bc Author: Adrian Irwin <mr.irwin@gmail.com> Date: Thu Nov 3 17:25:55 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet commit b1c2c27 Author: Adrian Irwin <adrianirwin@kpmg.com> Date: Thu Nov 3 16:57:56 2016 -0700 docs(router): fixed verbiage and example of how routed views are related to the router outlet * deactivate bugged tests

googlebot added the CLA: yes label Oct 30, 2016

wardbell suggested changes Oct 31, 2016

View reviewed changes

wardbell added the pr_state: blocked label Oct 31, 2016

brandonroberts force-pushed the router-observable-params branch 2 times, most recently from e48edd1 to 055e931 Compare November 2, 2016 02:35

wardbell approved these changes Nov 2, 2016

View reviewed changes

wardbell removed the pr_state: blocked label Nov 2, 2016

docs(router): Updated usage of observables in router tutorial and dev…

1afe5dc

…eloper guide Moved route configuration into separate variable for consistency Added async pipe to handle subscriptions for list items

wardbell force-pushed the router-observable-params branch from 055e931 to 1afe5dc Compare November 14, 2016 19:13

wardbell added the pr_state: LGTM label Nov 14, 2016

wardbell merged commit 5c4cc9a into angular:master Nov 14, 2016

wardbell deleted the router-observable-params branch November 14, 2016 20:43

docs(router): Updated usage of observables in tutorial and dev guide #2696

docs(router): Updated usage of observables in tutorial and dev guide #2696

Uh oh!

Conversation

brandonroberts commented Oct 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wardbell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wardbell Oct 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wardbell Oct 31, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brandonroberts commented Nov 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wardbell commented Nov 2, 2016

Uh oh!

wardbell commented Nov 14, 2016

Uh oh!

Uh oh!

brandonroberts commented Oct 30, 2016 •

edited

Loading

wardbell Oct 31, 2016 •

edited

Loading

wardbell Oct 31, 2016 •

edited

Loading

brandonroberts commented Nov 2, 2016 •

edited

Loading