Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(upgrade): update to final #2460

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

Foxandxss
Copy link
Member

@Foxandxss Foxandxss commented Sep 24, 2016

This is a big PR.

  • Includes updated examples (there are 4) using NgModule.
  • Update unit tests for final version.
  • Update prose to add all the relevant information for NgModule.
  • Update tooling to match latest releases.
  • Missing images, no more 404 errors.

Missing:

Notes:

  • The main AppModule (in the hybrid-2 example) is quite complicated, has a lot of docregions, but is still better than 8-10 copies of it. Works good, step by step.
  • There is one test (IMPORTANT, THERE ARE TWO COPIES OF IT) that is a xit. I wasn't able to make it work.
  • @wardbell revise the tests and change it your way if you want to, no prose change is needed regarding tests. For running the tests, you need to use the karma.conf.ng1.js file.
  • There are two disabled e2e tests. They need protractor 4.

@wardbell wardbell force-pushed the upgrade-latest-release branch from 7784b18 to ccd4155 Compare September 27, 2016 07:37
@wardbell wardbell merged commit 66c630d into angular:master Sep 27, 2016
@wardbell wardbell deleted the upgrade-latest-release branch September 27, 2016 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants