docs(upgrade): update to new router #2003
Conversation
Foxandxss
force-pushed
the
update-guide-router
branch
from
4211628 to
3647d75
Compare
|
Should we hold until |
|
Personally, no. Apart from this, lots to be done for rc5. Let's say this is for rc5 El 29 jul. 2016 21:40, "Ward Bell" notifications@github.com escribió:
|
|
Router changes LGTM. Some minor issues with spacing between closing brackets. |
|
@brandonroberts point them to me so I can fix that. |
| beforeEach(() => { | ||
| addProviders([ | ||
| { provide: Phone, useClass: MockPhone }, | ||
| { provide: '$routeParams', useValue: {phoneId: 'xyz'}}, |
There was a problem hiding this comment.
Closing bracket spacing
|
@Foxandxss I left some comments |
Foxandxss
force-pushed
the
update-guide-router
branch
from
3647d75 to
5dff264
Compare
|
This is not in sync with current release. Needs much work. Do not merge |
Foxandxss
force-pushed
the
update-guide-router
branch
from
5dff264 to
63542ff
Compare
Foxandxss
force-pushed
the
update-guide-router
branch
from
63542ff to
89e6076
Compare
|
No longer relevant. New pr is at #2460 |
I updated the tests but we need to be on new world to make those tests work better, such as mock the new router.