Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

example(toh-4,5): getHeroesSlowly() to return getHeroes() #2152

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/docs/_examples/toh-4/dart/lib/hero_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class HeroService {
// See the "Take it slow" appendix
// #docregion get-heroes-slowly
Future<List<Hero>> getHeroesSlowly() {
return new Future.delayed(const Duration(seconds: 2), () => mockHeroes);
return new Future.delayed(const Duration(seconds: 2), getHeroes);
}
// #enddocregion get-heroes-slowly
// #docregion
Expand Down
2 changes: 1 addition & 1 deletion public/docs/_examples/toh-4/dart/lib/hero_service_1.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class HeroService {
// #enddocregion getHeroes-stub, empty-class, final
/*
// #docregion getHeroes-stub
List<Hero> getHeroes() {}
List<Hero> getHeroes() {} // stub
// #enddocregion getHeroes-stub
*/
// #docregion final
Expand Down
3 changes: 1 addition & 2 deletions public/docs/_examples/toh-4/ts/app/hero.service.1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ export class HeroService {
// #enddocregion empty-class, getHeroes-stub, full
/*
// #docregion getHeroes-stub
getHeroes(): void {
}
getHeroes(): void {} // stub
// #enddocregion getHeroes-stub
*/
// #docregion full
Expand Down
4 changes: 2 additions & 2 deletions public/docs/_examples/toh-4/ts/app/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ export class HeroService {
// #docregion get-heroes-slowly
getHeroesSlowly(): Promise<Hero[]> {
return new Promise<Hero[]>(resolve =>
setTimeout(() => resolve(HEROES), 2000) // 2 seconds
);
setTimeout(resolve, 2000)) // delay 2 seconds
.then(() => this.getHeroes());
}
// #enddocregion get-heroes-slowly
// #docregion
Expand Down
3 changes: 1 addition & 2 deletions public/docs/_examples/toh-5/dart/lib/hero_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ import 'mock_heroes.dart';
class HeroService {
Future<List<Hero>> getHeroes() async => mockHeroes;

// See the "Take it slow" appendix
Future<List<Hero>> getHeroesSlowly() {
return new Future<List<Hero>>.delayed(
const Duration(seconds: 2), () => mockHeroes);
const Duration(seconds: 2), getHeroes);
}

// #docregion getHero
Expand Down
5 changes: 2 additions & 3 deletions public/docs/_examples/toh-5/ts/app/hero.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@ export class HeroService {
return Promise.resolve(HEROES);
}

// See the "Take it slow" appendix
getHeroesSlowly(): Promise<Hero[]> {
return new Promise<Hero[]>(resolve =>
setTimeout(() => resolve(HEROES), 2000) // 2 seconds
);
setTimeout(resolve, 2000)) // delay 2 seconds
.then(() => this.getHeroes());
}

// #docregion getHero
Expand Down