This repository was archived by the owner on Dec 4, 2017. It is now read-only.
example(toh-4,5): getHeroesSlowly() to return getHeroes() #2152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am good with it, but I am unsure if the new version is a bit harder to understand (the setTimeout changes). |
|
I think that it separates concerns so that the |
Have `getHeroesSlowly()` delay and then return the value of `getHeroes()`. This makes it easier for user’s performing the tutorial to keep this slower method as they evolve toh-5 into toh-6.
Have `getHeroesSlowly()` delay and then return the value of `getHeroes()`. This makes it easier for user’s performing the tutorial to keep this slower method as they evolve toh-5 into toh-6.
chalin
force-pushed
the
chalin-toh-4n5-get-heroes-slowly-0819
branch
from
705a045 to
03cedc4
Compare
|
@Foxandxss: can you tag as LGTM so that @wardbell can have a look at this too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have
getHeroesSlowly()delay and then return the value ofgetHeroes(). This makes it easier for user’s performing the tutorial to keep this slower method as they evolve toh-5 into toh-6.@kwalrath @Foxandxss @filipesilva : note that I've partitioned the files. There is a TS commit and a Dart commit, each ready to be reviewed.