Skip to content

run e2e tests under bazel #24338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2023
Merged

run e2e tests under bazel #24338

merged 4 commits into from
Feb 3, 2023

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Nov 28, 2022 •
edited
Loading

See the fixup commits for what changed since the last PR and what was reverted.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 28, 2022
@jbedard jbedard force-pushed the e2e branch 5 times, most recently from 93d8f86 to ec50232 Compare November 29, 2022 17:59
@angular-robot angular-robot bot removed the area: build & ci Related the build and CI infrastructure of the project label Nov 29, 2022
@alan-agius4
Copy link
Collaborator

@jbedard is this ready for review? As it's still marked as a draft.

@jbedard jbedard marked this pull request as ready for review December 13, 2022 18:06
@jbedard
Copy link
Contributor Author

jbedard commented Dec 18, 2022

@alan-agius4 yes I believe this was ready.. 🤔

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Jan 9, 2023
alan-agius4
alan-agius4 reviewed Jan 10, 2023
View reviewed changes
jbedard
jbedard commented Jan 21, 2023
View reviewed changes
@jbedard jbedard requested a review from alan-agius4 January 21, 2023 23:52
@jbedard
Copy link
Contributor Author

jbedard commented Jan 21, 2023

Updated, see the last two fixup commits (5923c93, 0259fd9).

@alan-agius4 alan-agius4 added the merge: squash commits When the PR is merged, a squash and merge should be performed label Jan 23, 2023
@alan-agius4
Copy link
Collaborator

@josephperrott PTAL.

josephperrott
josephperrott approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 2, 2023
@angular-robot angular-robot bot merged commit fac1e58 into angular:main Feb 3, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker merge: squash commits When the PR is merged, a squash and merge should be performed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbedard @alan-agius4 @josephperrott