Skip to content

Commit 5923c93

Browse files
committed
fixup! test: run legacy-cli e2e tests via bazel
1 parent a3264a3 commit 5923c93

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.circleci/dynamic_config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,13 +543,13 @@ workflows:
543543
snapshots: true
544544
pre-steps:
545545
- when:
546+
# Don't run snapshot E2E's unless it's on the main branch or the snapshots file has been updated.
546547
condition:
547548
and:
548549
- not:
549550
equal: [main, << pipeline.git.branch >>]
550551
- not: << pipeline.parameters.snapshot_changed >>
551552
steps:
552-
# Don't run snapshot E2E's unless it's on the main branch or the snapshots file has been updated.
553553
- run: circleci-agent step halt
554554
requires:
555555
- build
@@ -594,13 +594,13 @@ workflows:
594594
snapshots: true
595595
pre-steps:
596596
- when:
597+
# Don't run snapshot E2E's unless it's on the main branch or the snapshots file has been updated.
597598
condition:
598599
and:
599600
- not:
600601
equal: [main, << pipeline.git.branch >>]
601602
- not: << pipeline.parameters.snapshot_changed >>
602603
steps:
603-
# Don't run snapshot E2E's unless it's on the main branch or the snapshots file has been updated.
604604
- run: circleci-agent step halt
605605
requires:
606606
- bazel-build

packages/angular_devkit/build_angular/src/builders/karma/index.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,12 @@ function getBuiltInKarmaConfig(
222222
reporters: ['progress', 'kjhtml'],
223223
browsers: ['Chrome'],
224224
customLaunchers: {
225+
// Chrome configured to run in a bazel sandbox.
226+
// Disable the use of the gpu and `/dev/shm` because it causes Chrome to
227+
// crash on some environments.
228+
// See:
229+
// https://github.com/puppeteer/puppeteer/blob/v1.0.0/docs/troubleshooting.md#tips
230+
// https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t
225231
ChromeHeadlessNoSandbox: {
226232
base: 'ChromeHeadless',
227233
flags: ['--no-sandbox', '--headless', '--disable-gpu', '--disable-dev-shm-usage'],

0 commit comments

Comments
 (0)