Skip to content

refactor(@angular-devkit/schematics): Delete 'rename' rule #24000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

tvsbrent
Copy link

@tvsbrent tvsbrent commented Oct 3, 2022

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The rename rule exists in the source and is packaged, but is not exposed via the entrypoints.

Issue Number: N/A

What is the new behavior?

The rename rule is deleted from the source, as it was decided it was no longer wanted.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Note that the rule can be referenced directly, such as through a statement like this: import { rename } from '@angular-devkit/schematics/src/rules/rename.js';. However, since that isn't part of the publicly exposed API, deleting it shouldn't be considered a breaking change.

@tvsbrent tvsbrent closed this Oct 3, 2022
@tvsbrent tvsbrent reopened this Oct 3, 2022
@tvsbrent tvsbrent changed the title chore(@angular-devkit/schematics): Delete 'rename' rule refactor(@angular-devkit/schematics): Delete 'rename' rule Oct 3, 2022
- Based on discussion in closed PR angular#23673, delete `rename` rule.
@tvsbrent tvsbrent force-pushed the delete-rename-rule branch from fcab6da to c64d867 Compare October 3, 2022 21:35
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Oct 4, 2022
@clydin clydin merged commit 4a2f4dc into angular:main Oct 4, 2022
@tvsbrent tvsbrent deleted the delete-rename-rule branch October 4, 2022 13:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants