Skip to content

fix(@angular-devkit/schematics): Export 'rename' rule #23673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(@angular-devkit/schematics): Export 'rename' rule #23673

wants to merge 1 commit into from

Conversation

tvsbrent
Copy link

@tvsbrent tvsbrent commented Aug 2, 2022

  • Export the 'rename' rule.
    • The other rules in this directory are exported, so I assumed this one should
      be exported as well.

fix(@angular-devkit/schematics): Export 'rename' rule
41b7c90 
- Export the 'rename' rule.
  - The other rules in this directory are exported, so I assumed this one should
    be exported as well.
@tvsbrent tvsbrent force-pushed the export-rename-rule branch from f49d200 to 41b7c90 Compare August 3, 2022 12:45
@alan-agius4 alan-agius4 added needs: discussion On the agenda for team meeting to determine next steps and removed needs: discussion On the agenda for team meeting to determine next steps labels Sep 27, 2022
@alan-agius4
Copy link
Collaborator

@tvsbrent, thanks for your contribution and apologies for taking so long to get to this PR.

We have discussed this during our triage meeting and we decided that we should remove this Rule although.

Do you want to create a PR for that?

@tvsbrent
Copy link
Author

Thanks for the feedback! I can do that... although I've got some schematics I'd want to update first. 😄 I was a bad person and pulled a reference to rule directly, since it wasn't exported.

(Meaning, I did import { rename } from '@angular-devkit/schematics/src/rules/rename.js'; in my code.)

tvsbrent pushed a commit to tvsbrent/angular-cli that referenced this pull request Oct 3, 2022
chore(@angular-devkit/schematics): Delete 'rename' rule
5710445 
- Based on discussion in closed PR angular#23673, delete `rename` rule.
tvsbrent pushed a commit to tvsbrent/angular-cli that referenced this pull request Oct 3, 2022
refactor(@angular-devkit/schematics): Delete 'rename' rule
c81ca32 
- Based on discussion in closed PR angular#23673, delete `rename` rule.
@tvsbrent tvsbrent mentioned this pull request Oct 3, 2022
Merged
13 tasks
tvsbrent pushed a commit to tvsbrent/angular-cli that referenced this pull request Oct 3, 2022
refactor(@angular-devkit/schematics): Delete 'rename' rule
fcab6da 
- Based on discussion in closed PR angular#23673, delete `rename` rule.
tvsbrent pushed a commit to tvsbrent/angular-cli that referenced this pull request Oct 3, 2022
refactor(@angular-devkit/schematics): Delete 'rename' rule
c64d867 
- Based on discussion in closed PR angular#23673, delete `rename` rule.
clydin pushed a commit that referenced this pull request Oct 4, 2022
@clydin
refactor(@angular-devkit/schematics): Delete 'rename' rule
4a2f4dc 
- Based on discussion in closed PR #23673, delete `rename` rule.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvsbrent @alan-agius4