fix(@ngtools/webpack): fix rebuilds for transitive and global type deps

[filipesilva]

Fix #15856

[alan-agius4]

Wouldn't it be simpler to do something like?

this._typeDeps = newTsProgram
      .getSourceFiles()
      .filter(sf => sf.isDeclarationFile)
      .map(({ fileName }) => fileName);

in _createOrUpdateProgram which would also result for this fix to be available for VE compilations

[filipesilva]

Tried adding this at the end of the _createOrUpdateProgram method:

    console.log(newTsProgram!
      .getSourceFiles()
      .filter(sf => sf.isDeclarationFile && !sf.fileName.includes('node_modules'))
      .map(({ fileName }) => fileName))

Then I ran this test. It logged the following:

[ 'D:/work/cli/tests/angular_devkit/build_angular/test-project-host-hello-world-app-moqnlwoki9/src/typings.d.ts' ]
[ 'D:/work/cli/tests/angular_devkit/build_angular/test-project-host-hello-world-app-moqnlwoki9/src/typings.d.ts' ]
[ 'D:/work/cli/tests/angular_devkit/build_angular/test-project-host-hello-world-app-moqnlwoki9/src/typings.d.ts' ]
[ 'D:/work/cli/tests/angular_devkit/build_angular/test-project-host-hello-world-app-moqnlwoki9/src/typings.d.ts' ]
[ 'D:/work/cli/tests/angular_devkit/build_angular/test-project-host-hello-world-app-moqnlwoki9/src/typings.d.ts' ]

The typings only file was detected, but not the interface files.

[dgp1130]

There's a merge conflict attempting to get this into the 9.0.x patch branch. It seems a commit got missed in #16148, I'm following up there and once someone confirms, I will include that and merge this PR as well.

[dgp1130]

Confirmed that the extra commit in #16148 was an oversight. Merged that into the patch branch 9.0.x and was now able to merge this PR to it as well without any conflicts.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}