Skip to content

fix(@ngtools/webpack): recursive look up unused files #16148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

filipesilva
Copy link
Contributor

Fix #15626

@filipesilva filipesilva added the target: patch This PR is targeted for the next patch release label Nov 11, 2019
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 19, 2019

Looks like one of these commits was not included in the patch branch (8f4cee3) and is causing a merge conflict when attempting to merge #16164.

I'm assuming this was simply an oversight and not intentional. Can someone please confirm and I'll include it in the patch branch now.

@filipesilva
Copy link
Contributor Author

@dgp1130 that commit should have been in the patch branch, yes.

@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 20, 2019

Thanks @filipesilva, merged 8f4cee3 to 9.0.x patch branch. This PR should be all good.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ivy marks unassigned but used child interfaces as unused with compiler warning.
5 participants