-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: update hmr documentation #11029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like Travis ran into issues installing npm during a couple jobs.
I'm not seeing a way for me to force the job to run again. What's the best course of action here? |
Also #11093 |
Also #11121 🤣 |
@bniedermeyer this PR currently contains invalid json. I submitted a PR to your branch to fix it. |
This is currently pending #11144. Will rebase after it is merged in. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I'm ok with my commits being merged! I already signed the CLA too. Not sure why the bot changed the label (Bug?) |
Update documentation for the hmr story to show proper configurations in angular.json and src/tsconfig.app.json. Closes angular#11028, angular#10668, angular#10663
CLAs look good, thanks! |
Rebased after @hansl's doc pr was merged in. Good to go for review. |
Heya, thank you for updating this guide! I'll merge it now and it should be published next time we publish the wiki (probably for 6.1 final). |
how to fix |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update documentation for the hmr story to show proper configurations
in angular.json and src/tsconfig.app.json.
Closes #11028, #10668, #10663, #11093, #11121