Skip to content

docs: update hmr documentation #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

bniedermeyer
Copy link
Contributor

@bniedermeyer bniedermeyer commented May 26, 2018

Update documentation for the hmr story to show proper configurations
in angular.json and src/tsconfig.app.json.

Closes #11028, #10668, #10663, #11093, #11121

@bniedermeyer
Copy link
Contributor Author

Looks like Travis ran into issues installing npm during a couple jobs.

Updating nvm
nvm.install
3.54s$ nvm install 8
Downloading and installing node v8.11.2...
Downloading https://nodejs.org/dist/v8.11.2/node-v8.11.2-linux-x64.tar.xz...
Computing checksum with sha256sum
Checksums matched!
Now using node v8.11.2 (npm v5.6.0)
cache.1
Setting up build cache
$ export CASHER_DIR=$HOME/.casher
0.06s$ Installing caching utilities
0.00s
70.73sattempting to download cache archive
fetching PR.11029/cache-linux-trusty-7b1199fb7ff31509408e073597f37e53d115dda658128b74b8eb14a767d8cf9f--node-8.tgz
fetching PR.11029/cache--node-8.tgz
fetching master/cache-linux-trusty-7b1199fb7ff31509408e073597f37e53d115dda658128b74b8eb14a767d8cf9f--node-8.tgz
found cache
0.00s
7.44sadding /home/travis/build/angular/angular-cli/node_modules to cache
creating directory /home/travis/build/angular/angular-cli/node_modules
$ node --version
v8.11.2
$ npm --version
5.6.0
$ nvm --version
0.33.11
70.96s$ npm install -g npm@5.8.0
npm ERR! code E429
npm ERR! 429 Too Many Requests: npm@5.8.0
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-05-26T16_04_23_799Z-debug.log
The command "npm install -g npm@5.8.0" failed and exited with 1 during .

I'm not seeing a way for me to force the job to run again. What's the best course of action here?

@carlos-algms
Copy link

Also #11093

@robert-claypool
Copy link

Also #11121 🤣

@bniedermeyer
Copy link
Contributor Author

bniedermeyer commented Jun 6, 2018

@clydin or @Brocco, can you please take a look at the failing test when you get a second? This PR is just doc updates - it shouldn't touch anything that would be impacting the e2e test that is failing. All tests passed when run locally.

@ghost
Copy link

ghost commented Jun 6, 2018

@bniedermeyer this PR currently contains invalid json. I submitted a PR to your branch to fix it.

@bniedermeyer
Copy link
Contributor Author

bniedermeyer commented Jun 7, 2018

This is currently pending #11144. Will rebase after it is merged in.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 7, 2018
@ghost
Copy link

ghost commented Jun 8, 2018

I'm ok with my commits being merged! I already signed the CLA too. Not sure why the bot changed the label (Bug?)

Update documentation for the hmr story to show proper configurations
in angular.json and src/tsconfig.app.json.

Closes angular#11028, angular#10668, angular#10663
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jun 8, 2018
@bniedermeyer
Copy link
Contributor Author

Rebased after @hansl's doc pr was merged in. Good to go for review.

@filipesilva
Copy link
Contributor

Heya, thank you for updating this guide! I'll merge it now and it should be published next time we publish the wiki (probably for 6.1 final).

@FinalDes
Copy link

FinalDes commented Aug 21, 2018

how to fix
[ts] Element implicitly has an 'any' type because type 'NodeModule' has no index signature.
bug @filipesilva

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR not working according to the documentation
6 participants