Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Avoid bracking when combining with an Object #33

Closed
wants to merge 1 commit into from
Closed

Avoid bracking when combining with an Object #33

wants to merge 1 commit into from

Conversation

narcisoguillen
Copy link

Avoid having this error 'Uncaught TypeError: object is not a function' when sorting elements on the drop event

@thgreasi
Copy link
Contributor

How about iterating over the argument list (in a for loop), filtering out the invalid ones?

How this occured in the first place? An example fiddle would be nice.

@thgreasi
Copy link
Contributor

thgreasi commented Oct 3, 2013

Since this looks like #34 please elaborate on the issue (possibly with an example of the error).

thgreasi added a commit to thgreasi/ui-sortable that referenced this pull request Oct 3, 2013
…d added $log.info() message in case ngModel is falsy.

Possibly closes angular-ui#33 and angular-ui#34.
@thgreasi thgreasi closed this in #37 Oct 6, 2013
thgreasi added a commit that referenced this pull request Oct 6, 2013
Avoid breaking when ngModel is not provided.
Probably closes #33 and #34.
@thgreasi
Copy link
Contributor

thgreasi commented Oct 6, 2013

Please retest against master and re-open issue if necessary.
Demo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants