After update is called I get an obje is not a function error

[matthewswallace]

after moving an item in the list and update gets called I get the following in the console.

Uncaught TypeError: object is not a function sortable.js:17
(anonymous function) sortable.js:17
$.Widget._trigger jquery-ui.js:785
$.widget._trigger jquery-ui.js:4752
(anonymous function) jquery-ui.js:401
$.widget._clear jquery-ui.js:4743
(anonymous function) jquery-ui.js:401
$.widget._mouseStop jquery-ui.js:3933
(anonymous function) jquery-ui.js:401
$.widget._mouseUp jquery-ui.js:958
(anonymous function) jquery-ui.js:401
_mouseUpDelegate jquery-ui.js:914
jQuery.event.dispatch jquery-1.9.1.js:3074
elemData.handle

[thgreasi]

Can you provide a fiddle demonstrating the issue?

[tonybaroneee]

Fixed this by adding ng-model to the same element which ui-sortable is on (I had overlooked that on the setup doc).

[narcisoguillen]

I had the same issue, I fix this issue by making sure that the first argument of the combineCallbacks is actually a callback ( function ), it enters as null ( null is an object ) this happens on

// call apply after stop
opts.stop = combineCallbacks( opts.stop, apply );

Taking in mind that the callbacks initialize like

        var callbacks = {
            receive: null,
            remove:null,
            start:null,
            stop:null,
            update:null
        };

opts enter to the combineCallbacks as: {receive: null, remove: null, start: null, stop: null, update: null};

[thgreasi]

Is this an issue even if ngModel is defined?

[narcisoguillen]

<ul ng-model='sort' ui-sortable="sortableOptions">
 //... HTML CODE
</ul>

issue persists.

[thgreasi]

Here is the demo found in the source code in codePen.
Seems to work. If your setup is different, please fell free to demonstrate.

BUT, not providing ngModel is wrong, since ui.sortable will not know which model it should update.
if you bypass the error (by providing a stop callback or by changing the code of ui.sortable), then you can see that the model does not get updated. This is equivalent to just using jqui sortable on a non-angular application.
Here is a no ngModel + bypass pen that demonstrates that the model does not get updated. Feel free fork it and demonstrate your case.

I intend to create a PR that:

1. will enclose all the code till "opts.stop = combineCallbacks( opts.stop, apply );" inside the "if (ngModel) { ... }' 2) and add a $log that should state that the ngModel is missing.

[narcisoguillen]

not sure what is going wrong. this is what I have on my controller

$scope.sortableOptions = {
update: function(e, ui){
//.. stuff
},
stop: function(){
//.. stuff
}
};

[thgreasi]

Created a codePen with PR37 that demonstrates the behavior in case ngModel is not provided.
Note that even when stop is not provided, execution does not break. A log is written (about the missing ngModel) instead. Then, the list works like a regular jquery-ui sortable widget.

Should this issue be closed?

[thgreasi]

Any results yet?

[thgreasi]

Please retest against master and re-open issue if necessary.
Demo