This repository was archived by the owner on Sep 8, 2020. It is now read-only.
feat(sortable): add support for the case that debugInfo is disabled #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var droptargetScope = null; | ||
| angular.forEach(ui.item.sortable._connectedSortables, function(x) { | ||
| if (x.element[0] === droptarget[0]) { | ||
| droptargetScope = x.scope; |
There was a problem hiding this comment.
Any reason to not return after finding the droptargetScope? It seems like it'd be useful, performance-wise, to bail early, but I may be missing something.
There was a problem hiding this comment.
This was written at 7:30 am before I leave for work and obviously I was lazy enough to write a for loop...
I'm going to change it to use a for before merging and possibly refractor it to a getDroptargetScope function.
thgreasi
force-pushed
the
debugInfoEnabled
branch
from
3f72c2f to
c4eae05
Compare
thgreasi
force-pushed
the
debugInfoEnabled
branch
from
c4eae05 to
0a0d216
Compare
thgreasi
force-pushed
the
debugInfoEnabled
branch
from
0ad3250 to
9ef4622
Compare
thgreasi
added a commit
that referenced
this pull request
Jan 20, 2015
feat(sortable): add support for the case that debugInfo is disabled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finished resolve #291.