UI-Sortable is Dependent on DebugInfo Being Enabled

[fishfacemcgee]

I noticed that, after I started using $compileProvider.debugInfoEnabled(false) in my my main app module, certain areas using ui-sortable stopped working correctly. On this line in sortable.js, we're using the scope() method on an element, which is apparently only available when debugInfo is active. If we can find a way to get that information without relying on the debug information, that would allow for significant performance improvements by killing debug info outright.

[thgreasi]

Can you confirm that v0.12.x works for your use case with debugInfo disabled?
Actually .scope() is executed on an element only to fill ui.item.sortable.droptargetModel.
Moreover, droptargetModel is not used internally and is provided to help the developer easily find the model of the receiving sortable inside the first update() call, so that he can decide early enough if he wants to call cancel().
So, for now you can comment out the aforementioned line or use v0.12.x branch, if you don't really need ui-sortable to find droptargetModel for you.

On the other hand, I might have found a solution and as soon as I find some time, I will create a new branch that works when debugInfo is disabled.

[ashgibson]

I can confirm this issue is still happening in 0.13.1. When debugInfoEnabled = false, the following error is displayed in chrome console:

"Uncaught TypeError: Cannot read property '$eval' of undefined" sortable.js:156.

[thgreasi]

@fishfacemcgee, @smartfaceweb can you give my new (badly named) branch some testing?
It should work, it's just the tests that are pending.

[ashgibson]

@thgreasi it works for me, thanks!

Your updated sortable.js looks a lot different to v0.13.1 on angular-ui/ui-sortable with the combineCallbacks function removed and a lot of other tidy up. I've had a look through the git history but can't see where this changed. I am a bit of a noob, can you point me in the right direction.

[thgreasi]

That's not true, it's still there.
I just opened PR #314 so you can spot the differences easily.

[ashgibson]

Great. Looking forward to the merge so I can update via bower.

[thgreasi]

#314 seems finished.
If your feedback is OK then this could be merged by tomorrow/the weekend.

[rainder]

experiencing same issue. waiting for a release. thank you!

[thgreasi]

Can you provide some feedback on the branch found in #314?