This repository was archived by the owner on Sep 20, 2019. It is now read-only.
fix(markers): fix default icon for retina screens #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it is a bit related to #299.
We provide base64 version for the icon and shadow but not for the retinaIcon. Thus, Leaflet fallbacks to the default one but since we set the
imagePathoption, the image can't be found (actually, on my production application, the images are not even on the server since we use the base64 ones in ui-leaflet).Therefore, this PR simply adds a base64 icon version for the
iconRetinaUrloption.