fix(Markers): fix marker icon broken with latest Leaflet version (1.0)

[ValentinH]

Leaflet now tries to auto-detect the path for the icons, but when using a base64 one, it breaks.
Thus, we need to force the imagePath to be ' '.
See this line in Leaflet source: https://github.com/Leaflet/Leaflet/blob/master/src/layer/marker/Icon.Default.js#L36

Broken demo: http://jsfiddle.net/ar2bo629/
Fixed Demo: http://jsfiddle.net/f7bq9v6b/

[nmccready]

Anyway you can add a spec to assert this fix stay around?

[nmccready]

Unit tests to make sure base64 icons work.

[ValentinH]

Where should I add this test?

[nmccready]

@ValentinH https://github.com/angular-ui/ui-leaflet/blob/master/test/unit/services/leafletMarkersHelpersSpec.coffee

[ValentinH]

coffeescript? 😢
Is there a way where I can add tests in JS?

[nmccready]

coffeescript? 😢
Is there a way where I can add tests in JS?

Seriously?, coffee is not much different then js, learn something new please. Otherwise add a leafletMarkersHelpersSpec.js file and ill convert it.

Coffee is not end of the world.

[elesdoar]

@ValentinH don't worry, you can write test in JS, but the new ES6 or ES7 looks like Coffee, but keep in coffee tests that are in coffee.

You could use http://js2.coffee/

[ValentinH]

Sorry, I was a bit trolling! 👿

But I think that having tests in Coffeescript is not really good to encourage new contributors to provide tests with their PR. Indeed, Coffeescript is not really use anymore today...

[ValentinH]

Don't worry, I will do it in coffee when I have some time.

[elesdoar]

I think that we have to go ES6 or ES7, but change all coffee specs requires a lot of work.

@ValentinH if you want you can translate this test to JS, but takes full advantages of ES6.

[ValentinH]

What do you mean by take full advantages?

[elesdoar]

@ValentinH
Sorry for my bad explanation, it's so hard write in english. jaajaja... 😢

I mean that use arrow functions, template strings, classes, etc. Obviously where needed.
Please check http://es6-features.org

[nmccready]

I think the master branch already supports babel, so you can write ES6 there. I just prefer Coffee for specs cause its a whole lot less hassel for nested bracket and variable declaration. Plus I wrote a lot of the specs and to get them done fast I chose coffee.

I still don't think ES6 is like coffee at all the arrow function means something much different in ES6 since you cant call apply or call to pass a different this on a function. Anyway, I could go on but ES6 is better for sure since it has structuring and destructuring.

[ValentinH]

Actually, I don't know how to test this. Currently, there is no test for marker/icon creations so I can't really understand from where to start. Thus, I wont' add test in this PR.

[elesdoar]

OK, I'll merging the change and I'll do this test.

Thanks @ValentinH