Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix(position): for SVG elements #1225

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/position/position.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ angular.module('ui.bootstrap.position', [])
offsetParentBCR.left += offsetParentEl.clientLeft - offsetParentEl.scrollLeft;
}

var boundingClientRect = element[0].getBoundingClientRect();
return {
width: element.prop('offsetWidth'),
height: element.prop('offsetHeight'),
width: boundingClientRect.width || element.prop('offsetWidth'),
height: boundingClientRect.height || element.prop('offsetHeight'),
top: elBCR.top - offsetParentBCR.top,
left: elBCR.left - offsetParentBCR.left
};
Expand All @@ -69,8 +70,8 @@ angular.module('ui.bootstrap.position', [])
offset: function (element) {
var boundingClientRect = element[0].getBoundingClientRect();
return {
width: element.prop('offsetWidth'),
height: element.prop('offsetHeight'),
width: boundingClientRect.width || element.prop('offsetWidth'),
height: boundingClientRect.height || element.prop('offsetHeight'),
top: boundingClientRect.top + ($window.pageYOffset || $document[0].body.scrollTop || $document[0].documentElement.scrollTop),
left: boundingClientRect.left + ($window.pageXOffset || $document[0].body.scrollLeft || $document[0].documentElement.scrollLeft)
};
Expand Down
18 changes: 17 additions & 1 deletion src/position/test/test.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@
elPosition.left += elPosition.width;

positionedEl.css({left: elPosition.left + 'px', top: elPosition.top + 'px'});
element.after($compile(positionedEl)(scope));

if (attrs['position'] === 'body') {
angular.element(document.getElementsByTagName('body')[0]).after($compile(positionedEl)(scope));
} else {
element.after($compile(positionedEl)(scope));
}
}
};
});
Expand Down Expand Up @@ -110,6 +115,15 @@ <h3>Within a table that is inside a relative-positioned DIV</h3>
</table>
</div>

<h3>Inside svg</h3>

<svg height="300px" width="300px">
<rect x="0" y="0" height="300" width="300" fill="aliceblue"></rect>
<rect x="50" y="50" height="200" width="200" position="body" fill="white" stroke="red">
</rect>
</svg>


<h3>Inside looong text</h3>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur non velit nulla. Suspendisse sit amet tempus diam. Sed at ultricies neque. Suspendisse id felis a sem placerat ornare. Donec auctor, purus at molestie tempor, arcu enim molestie lacus, ac imperdiet massa urna eu massa. Praesent velit tellus, scelerisque a fermentum ut, ornare in diam. Phasellus egestas molestie feugiat. Vivamus sit amet viverra metus.</p>
<p>Etiam ultricies odio commodo erat ullamcorper sodales. Nullam ac dui ac libero dictum mollis. Quisque convallis adipiscing facilisis. In nec nisi velit, id auctor lectus. Cras interdum urna non felis lacinia vulputate. Integer dignissim, mi aliquam gravida auctor, massa odio cursus lorem, eu ultrices eros nisl tempus diam. Maecenas tristique pellentesque nisi sed adipiscing. Aenean hendrerit sapien quis arcu lobortis vitae pulvinar ante volutpat. Morbi consectetur erat eu lacus facilisis eu ullamcorper orci euismod. Quisque diam dui, interdum in suscipit et, fringilla non justo. Pellentesque non nibh odio. Proin sit amet massa sem.</p>
Expand All @@ -119,10 +133,12 @@ <h3>Inside looong text</h3>
<div class="content" position>HERE</div>
<p>Maecenas laoreet nisi pretium elit bibendum eget tempor nunc aliquet. Vivamus interdum nisi sit amet tortor fermentum congue. Suspendisse at posuere erat. Aliquam hendrerit ultricies nunc non adipiscing. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Duis molestie viverra nulla a aliquet. Nullam non eros vel sem vehicula suscipit. Ut sit amet arcu ac tortor dignissim viverra in a ligula.</p>


<div style="position: fixed; bottom: 0" class="container">
<h3>Within fixed div</h3>
<div class="content" position>Content</div>
</div>


</body>
</html>