This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(position): for SVG elements #1225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap tooltips calculate the `width` and `height` of elements using first getBoundingClientRect and fall back to `offsetWidth` and `offsetHeight` if it is not available: https://github.com/twbs/bootstrap/blob/master/js/tooltip.js#L297 This fixes a problem with tooltips/popovers on SVG elements in Firefox: twbs/bootstrap#5956 This change mimics that behavior.
|
Totally awesome pull request @musically-ut , you rock! If only half of PRs would be of this quality, GitHub would be a better place. Going to merge it later today. |
|
Thanks for the warm fuzzy feeling. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap tooltips calculate the
widthandheightof elementsusing first getBoundingClientRect and fall back to
offsetWidthandoffsetHeightif it is not available:https://github.com/twbs/bootstrap/blob/master/js/tooltip.js#L297
This fixes a problem with tooltips/popovers on SVG elements in
Firefox: twbs/bootstrap#5956
This change mimics that behavior.
I have also added a test case for the scenario.
Buggy behaviour:
Fixed behaviour: