Skip to content

small typos in julia code that could be a problem in other languages. Added abs and fixed <= #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2021
Merged

small typos in julia code that could be a problem in other languages. Added abs and fixed <= #840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04259b7
small typo in julia code that could be a problem in other languages
leios Aug 23, 2021
7f8d269
adding absolute value to approximate counting tests in Julia
leios Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contents/approximate_counting/code/julia/approximate_counting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function increment(v, a)
delta = 1/(n(v+1, a)-n(v, a))

if rand() <= delta
return v += 1
return v + 1
else
return v
end
Expand Down Expand Up @@ -47,7 +47,7 @@ function test_approximate_count(n_trials, n_items, a, threshold)

avg = sum(samples)/n_trials

@test ((avg - n_items) / n_items < threshold)
@test (abs((avg - n_items) / n_items) < threshold)
end

@testset "Counting Tests, 100 trials" begin
Expand Down