Skip to content

small typos in julia code that could be a problem in other languages. Added abs and fixed <= #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

leios
Copy link
Member

@leios leios commented Aug 23, 2021

This was brought up in the discussion of #834

Feel free to make other comments about the code on this PR!

@Amaras Amaras added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Aug 23, 2021
Copy link
Contributor

@mika314 mika314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leios
Copy link
Member Author

leios commented Aug 24, 2021

This now also fixes #843

@mika314
Copy link
Contributor

mika314 commented Aug 24, 2021

Maybe update the PR title for clarety?

@leios leios changed the title small typo in julia code that could be a problem in other languages small typos in julia code that could be a problem in other languages. Added abs and fixed <= Aug 24, 2021
@leios leios merged commit 139c4a1 into algorithm-archivists:master Aug 24, 2021
@leios leios deleted the julia_counting_fix branch August 24, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants