Skip to content

Update C# Jarvis March to use points from Graham Scan #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2021
Merged

Update C# Jarvis March to use points from Graham Scan #705

merged 1 commit into from
Aug 28, 2021

Conversation

berquist
Copy link
Member

This uses the points from

algorithm-archive/contents/graham_scan/code/julia/graham.jl

Line 50 in 4313e7e

Point(-5,2), Point(5,7), Point(-6,-12), Point(-14,-14), Point(9,9),

@berquist berquist added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label May 24, 2020
@ntindle
Copy link
Member

ntindle commented Aug 28, 2021

[lang: c#]

@github-actions github-actions bot added the lang: c# C# programming language label Aug 28, 2021
stormofice
stormofice approved these changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@stormofice stormofice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the PR.

As this code was already reviewed in #85 and this just changes the used points to conform with the other implementations, I think this can be merged.

Related PRs where this already has been discussed and merge are #706 and #708 .

Amaras
Amaras approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just a uniformization PR, I'm just gonna go ahead and merge this.

@Amaras Amaras merged commit 888235d into algorithm-archivists:master Aug 28, 2021
@berquist berquist deleted the jarvis-march-csharp-points branch September 6, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amaras Amaras Amaras approved these changes

@stormofice stormofice stormofice approved these changes

Assignees
No one assigned
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) lang: c# C# programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berquist @ntindle @Amaras @stormofice