Skip to content

Update JavaScript Jarvis March to use points from Graham Scan #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

berquist
Copy link
Member

This uses the points from

Point(-5,2), Point(5,7), Point(-6,-12), Point(-14,-14), Point(9,9),

@berquist berquist added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label May 24, 2020
@leios
Copy link
Member

leios commented May 24, 2020

I think @jiegillet did something with the Haskell code such that these numbers were not "magic," but instead pulled from some distribution, but I don't remember the trick. I think he just randomly picked a distribution from within a circle, but I don't remember how he knew which points should be excluded.

I can look into this in a bit.

Thanks a bunch for all the PR work recently!

@berquist
Copy link
Member Author

I see. If we can find out, then that information should be at the end of the chapter. Of course, hold off on all the related PRs until we get that information.

@jiegillet
Copy link
Member

jiegillet commented May 25, 2020

I made the points this way:

let pts = [(x,y) | x<-[-5..5], y<-[-5..5], x^2+y^2<=5^2]

which means, take all integer points on a square grid from (-5,-5) to (5,5) and keep the ones inside or on a circle of radius 5.

@ntindle
Copy link
Member

ntindle commented Aug 28, 2021

[lang: javascript]

@github-actions github-actions bot added the lang: javascript Javascript programming language label Aug 28, 2021
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge this soon

@Amaras Amaras merged commit ff494db into algorithm-archivists:main Dec 8, 2021
@berquist berquist deleted the jarvis-march-javascript-points branch December 29, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) lang: javascript Javascript programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants