Make Python Jarvis March conform to PEP8, take 2 #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
added
the
Implementation Edit
|
It looks like the filename was changed, could you also update the markdown file to reflect this? Outside of that, it looks good |
berquist
force-pushed
the
jarvis-march-python-cleanup
branch
from
76ba9d0 to
8f70ea2
Compare
|
Ok, check again. |
leios
approved these changes
Dec 28, 2018
|
Shoot, screwed up. I squashed and merged. Sorry about that. We can fix it, but I think we might just need to live with the changes. I'll be more careful from now on. |
|
I don't think it matters too much; it was more about the review itself so one can see the lines that were actually changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redo of #507. In order to make the changes clearer, this shouldn't be a squash/rebase and merge, so the filename change and line changes are kept separate properly.
Check the second commit for the actual diff. Or, maybe the rename should be a separate PR?