Skip to content

Make Python Jarvis March conform to PEP8 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make Python Jarvis March conform to PEP8 #507

wants to merge 1 commit into from

Conversation

berquist
Copy link
Member

No description provided.

@berquist berquist added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 13, 2018
@jiegillet
Copy link
Member

It's hard to see the differences when GitHub considers a name change like a file deletion. Maybe in the future we should encourage people to change the name in a commit after the changes have been reviewed :(

@Butt4cak3
Copy link
Contributor

change the name in a commit after the changes have been reviewed

Or just in a separate commit. It's easy enough to exclude that from a diff locally.

leios
leios approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a straightforward port with PEP8. I approve of these changes; however, I'll let someone else merge... because I feel like I'm am missing something.

@berquist
Copy link
Member Author

Don't merge this, I'll split it.

@berquist berquist closed this Oct 17, 2018
@berquist berquist mentioned this pull request Dec 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

Assignees
No one assigned
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berquist @jiegillet @Butt4cak3 @leios