Add Graham Scan in Java #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
Implementation
zsparal
suggested changes
Oct 9, 2018
| return 0; | ||
| }; | ||
|
|
||
| hull.sort(angleComparator); |
There was a problem hiding this comment.
The code in this method up to this point could be written as:
gift = gift
.stream()
.distinct()
.sorted(Comparator.comparingDouble(point -> -point.y))
.collect(Collectors.toList());
Point pivot = gift.get(0);
// Sort the remaining Points based on the angle between the pivot and itself
List<Point> hull = gift.subList(1, gift.size());
hull.sort(Comparator.comparingDouble(point -> polarAngle(point, pivot)));which I think is a bit more readable.
| } | ||
|
|
||
| public static void main(String[] args) { | ||
| ArrayList<Point> points = new ArrayList<Point>(); |
There was a problem hiding this comment.
It's good practice to not repeat type parameters when it's not necessary:
ArrayList<Point> points = new ArrayList<>();|
|
||
| List<Point> convexHull = grahamScan(points); | ||
|
|
||
| convexHull.stream().forEach(p -> System.out.printf("% 1.0f, % 1.0f\n", p.x, p.y)); |
There was a problem hiding this comment.
You don't need the .stream() here, List<T> already has a forEach method.
zsparal
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.