-
-
Notifications
You must be signed in to change notification settings - Fork 359
add Scala implementation for Euclidean #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jiegillet
merged 10 commits into
algorithm-archivists:master
from
kenpower:euclidean_in_scala
Oct 5, 2018
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ca4a1f7
add Scala example for Euclidean
281537c
deal with negative args and zero
53763f1
deal with negative args and zero
84e1841
Merge branch 'euclidean_in_scala' of https://github.com/kenpower/algo…
5f761e5
rename function
3c6457b
Merge branch 'master' of https://github.com/algorithm-archivists/algo…
c6ffce1
change method name
f80bc47
Merge branch 'master' of https://github.com/algorithm-archivists/algo…
d39bfb2
fix typo
6f87fa6
Merge branch 'master' of https://github.com/algorithm-archivists/algo…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
object Euclid { | ||
|
||
def euclid(a: Int, b: Int):Int = | ||
(a,b) match{ | ||
case (x, y) if x < y => euclid(x, y-x) | ||
case (x, y) if x > y => euclid(x-y, y) | ||
case _ => a | ||
} | ||
|
||
def euclid_mod(a: Int, b: Int):Int = | ||
b match{ | ||
case 0 => a | ||
case _ => euclid_mod(b, a % b) | ||
} | ||
|
||
def main(args: Array[String]): Unit = | ||
println(euclid(135749,27482)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you write these numbers as their prime decomposition? Just so its obvious what the answer should be. |
||
println(euclid_mod(135749,27482)) | ||
|
||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. End the file on a newline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most other implementations take the absolute value of the input to avoid problems with negative numbers. Maybe you could have a wrapper that takes care of that, and also the case when one number is zero while we're at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, forgot about that.