add Scala implementation for Euclidean #427
Conversation
Gathros
added
Implementation
| println(euclid(135749,27482)) | ||
| println(euclid_mod(135749,27482)) | ||
|
|
||
| } |
| } | ||
|
|
||
| def main(args: Array[String]): Unit = | ||
| println(euclid(135749,27482)) |
There was a problem hiding this comment.
Could you write these numbers as their prime decomposition? Just so its obvious what the answer should be.
| object Euclid { | ||
|
|
||
| def euclid(a: Int, b: Int):Int = | ||
| (a,b) match{ |
There was a problem hiding this comment.
Most other implementations take the absolute value of the input to avoid problems with negative numbers. Maybe you could have a wrapper that takes care of that, and also the case when one number is zero while we're at it.
There was a problem hiding this comment.
Thanks, forgot about that.
| @@ -0,0 +1,22 @@ | |||
| object Euclid { | |||
|
|
|||
| def euclid(a: Int, b: Int): Int = | |||
There was a problem hiding this comment.
Could you rename it to euclid_sub?
There was a problem hiding this comment.
OK. You're concerned about having Euclid and euclid in same namespace?
There was a problem hiding this comment.
Not really, it's just more readable when you have 2 methods based on subtraction and modulo
…rithm-archive into euclidean_in_scala
…rithm-archive into euclidean_in_scala
…rithm-archive into euclidean_in_scala
* add Scala example for Euclidean * deal with negative args and zero * deal with negative args and zero * rename function * change method name * fix typo
No description provided.