Skip to content

Add Emojicode Bogo Sort implementation. #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2018
Merged

Add Emojicode Bogo Sort implementation. #424

merged 4 commits into from
Oct 8, 2018

Conversation

june128
Copy link
Member

@june128 june128 commented Oct 3, 2018

Depends on #423 (the necessary changes to the .editorconfig and book.json get made there).

@june128 june128 added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 3, 2018
@june128 june128 changed the title WIP Add Emojicode Bogo Sort implementation. Add Emojicode Bogo Sort implementation. Oct 4, 2018
nic-hartley
nic-hartley approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@nic-hartley nic-hartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... code looks alright. I can barely read it, but the only change I'd suggest is "use a different language", which isn't very constructive.

jiegillet
jiegillet approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @thbwd

@jiegillet jiegillet merged commit 8226655 into master Oct 8, 2018
@june128 june128 deleted the bogo_sort_emojicode branch October 8, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-hartley nic-hartley nic-hartley approved these changes

@thbwd thbwd thbwd approved these changes

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@june128 @nic-hartley @thbwd @jiegillet