Emojicode bubble sort implementation. #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
Implementation
- Me during today's stream I must admit: It's hard to resist the urge. |
|
First off, I think it’s great someone finally adds a real language to this project. 😉 You can, however, improve your code by taking advantage of that fact that lists are in fact iterable: is enough to print the list. |
|
Feel free to review the code, if you want! |
thbwd
suggested changes
Oct 3, 2018
| 🍨 1.7 -3.0 2.5 2.0 -6.0 4.4 50.0 7.0 1.5 -4.3 0.3 🍆 ➡️ numbers | ||
|
|
||
| 😀 🔤unordered:🔤❗️ | ||
| 🔂 i 🆕⏩⏩ 0 🐔 numbers❗️❗️ 🍇 |
There was a problem hiding this comment.
I’d recommend to change this to
🔂 number numbers 🍇
😀 🔡 number 10❗️❗️
🍉
| 🛁🐇🥇 numbers❗️ | ||
|
|
||
| 😀 🔤ordered:🔤❗️ | ||
| 🔂 i 🆕⏩⏩ 0 🐔 numbers❗️❗️ 🍇 |
|
@thbwd Thanks for the review! I applied the suggested changes. |
thbwd
approved these changes
Oct 3, 2018
|
If @thbwd approves, I also approve. Thanks for the review! |
leios
approved these changes
Oct 3, 2018
kenpower
pushed a commit
to kenpower/algorithm-archive
that referenced
this pull request
Oct 22, 2018
* Add emojicode to the editorconfig and "book.json". * Add Emojicode Bubble Sort. * Make use of the fact, that lists are iterable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emojicode documentation and more: https://www.emojicode.org/