Added Euclidean Algorithm for lisp #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation
berquist
requested changes
Aug 9, 2018
| @@ -0,0 +1,18 @@ | |||
| ;;;;Bubble sort implementation | |||
There was a problem hiding this comment.
You added this file by accident.
| @@ -0,0 +1,15 @@ | |||
| (defun euclid_sub (a b) | |||
There was a problem hiding this comment.
The naming convention is to use kebab-case (https://en.wikipedia.org/wiki/Naming_convention_(programming)#Lisp), so replace the underscores with dashes.
|
|
||
| ;; built-in funciton: (gcd 80 40) | ||
| (print (euclid_sub 24 27)) ;should output 3 | ||
| (print (euclid_mod 90 27)) ;should output 9 |
There was a problem hiding this comment.
I would use the same example as the Clojure file:
(print
(euclid-sub (* 64 67)
(* 64 81)))
(print
(euclid-mod (* 128 12)
(* 128 77)))
There was a problem hiding this comment.
super minor: the comment misspells "funciton"
| a | ||
| (euclid_mod b (mod a b)))) | ||
|
|
||
| ;; built-in funciton: (gcd 80 40) |
There was a problem hiding this comment.
funciton -> function- I would actually execute this code. Even better, you can compare against your implementation:
(assert (= (euclid-sub (* 64 67) (* 64 81))
(gcd (* 64 67) (* 64 81))))
CONTRIBUTORS.md
Outdated
| @@ -57,3 +57,5 @@ NIFR91 | |||
| Michal Hanajik | |||
| <br> | |||
| Bendik Samseth | |||
| Trashtalk | |||
| Trashtalk | |||
There was a problem hiding this comment.
Since you've already done this as part of #348, you'll need to undo these changes.
berquist
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.