-
Notifications
You must be signed in to change notification settings - Fork 9
Update to examples link in README.rst #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Found a typo in the URL for the examples that led to a dead-end. Updated to: https://github.com/adafruit/Adafruit_CircuitPython_STMPE610/tree/master/examples. Don't know if this is the proper URL to use, but that's what I get if I traverse to the examples from the main repo page.
README.rst
Outdated
@@ -30,7 +30,8 @@ This is easily achieved by downloading | |||
Usage Example | |||
============= | |||
|
|||
see examples in githup repository: https://github.com/adafruit/Adafruit_CircuitPython_STMPE610/exmaples | |||
See examples in githup repository: https://github.com/adafruit/Adafruit_CircuitPython_STMPE610/tree/master/examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the other typo to say github? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me why this change is necessary or correct? What is wrong with the original URL? (Other than the githup in the comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makermelissa - Yes, I can. Funny that I missed that.
@jerryneedell - The URL took me to a 404 error page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerryneedell, https://github.com/adafruit/Adafruit_CircuitPython_STMPE610/exmaples went to a 404 not found page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes- never mind- I see now that the update is correct —and it works! Sorry for the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the fix.
My pleasure. Good catch on the other typo. Thanks. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.1.2 from 1.1.0: > pylint fix > text fixes, product ID update Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.2 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#32 from seantibor/master Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#8 from jpecor/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#11 from tannewt/improve_preload
Found a typo in the URL for the examples that led to a dead-end. Updated to:
https://github.com/adafruit/Adafruit_CircuitPython_STMPE610/tree/master/examples. Don't know if this is the proper URL to use, but that's what I get if I traverse to the examples from the main repo page.