Speed up preloads with duplicate code points #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic wouldn't recognize duplicate characters in the given set to preload and therefore it'd read the whole font file looking for a character it already found. A set deduplicates the given characters at a small memory cost.
|
omgggg im so happy |
ladyada
approved these changes
May 22, 2019
|
I just tried this out on my Nametag PyBadge code and it loaded SO much faster. Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 23, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.1.2 from 1.1.0: > pylint fix > text fixes, product ID update Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.2 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#32 from seantibor/master Updating https://github.com/adafruit/Adafruit_CircuitPython_STMPE610 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_STMPE610#8 from jpecor/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#11 from tannewt/improve_preload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic wouldn't recognize duplicate characters
in the given set to preload and therefore it'd read the whole
font file looking for a character it already found. A set
deduplicates the given characters at a small memory cost.
This drops the font preload for PyPortal from 22 seconds
to just over 2 seconds. (The preload string has duplicate
exclamation points.)