Linted #54
Merged
Linted #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disabled duplicate code |
kattni
suggested changes
Nov 5, 2021
adafruit_portalbase/__init__.py
Outdated
| string = "{:,d}".format(int(values[value_index])) | ||
| string = "{:,d}".format( | ||
| int(values[value_index]) | ||
| ) # pylint: disable=consider-using-f-string |
There was a problem hiding this comment.
Why is this needed? This is disabled in the .pre-commit-config.yml file.
There was a problem hiding this comment.
@kattni Oh hah yeah you're right. I need to figure out how to get vim to default to the repos pylintrc but I think it could have also had something to do with doing this at 3AM
kattni
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.