Merge pull request #54 from adafruit/patch-fix

Linted

Author: kattni

.pre-commit-config.yaml

@@ -24,7 +24,7 @@ repos:
         name: pylint (library code)
         types: [python]
         args:
-          - --disable=consider-using-f-string
+          - --disable=consider-using-f-string,duplicate-code
         exclude: "^(docs/|examples/|tests/|setup.py$)"
     -   id: pylint
         name: pylint (example code)

adafruit_portalbase/__init__.py

@@ -391,7 +391,7 @@ def _fill_text_labels(self, values):
         # fill out all the text blocks
         if self._text:
             value_index = 0  # In case values and text is not the same
-            for i in range(len(self._text)):
+            for i in range(len(self._text)):  # pylint: disable=consider-using-enumerate
                 if (not self._text[i]["is_data"]) or (value_index > (len(values) - 1)):
                     continue
                 string = None

adafruit_portalbase/graphics.py

@@ -81,8 +81,8 @@ def set_background(self, file_or_color, position=None):
         if self._bg_file:
             self._bg_file.close()
         if isinstance(file_or_color, str):  # its a filenme:
-            self._bg_file = open(file_or_color, "rb")
-            background = displayio.OnDiskBitmap(self._bg_file)
+            with open(file_or_color, "rb") as self._bg_file:
+                background = displayio.OnDiskBitmap(self._bg_file)
             self._bg_sprite = displayio.TileGrid(
                 background,
                 pixel_shader=getattr(

adafruit_portalbase/network.py

@@ -290,22 +290,21 @@ def wget(self, url, filename, *, chunk_size=12000):
         remaining = content_length
         print("Saving data to ", filename)
         stamp = time.monotonic()
-        file = open(filename, "wb")
-        for i in response.iter_content(min(remaining, chunk_size)):  # huge chunks!
-            self.neo_status(STATUS_DOWNLOADING)
-            remaining -= len(i)
-            file.write(i)
-            if self._debug:
-                print(
-                    "Read %d bytes, %d remaining"
-                    % (content_length - remaining, remaining)
-                )
-            else:
-                print(".", end="")
-            if not remaining:
-                break
-            self.neo_status(STATUS_FETCHING)
-        file.close()
+        with open(filename, "wb") as file:
+            for i in response.iter_content(min(remaining, chunk_size)):  # huge chunks!
+                self.neo_status(STATUS_DOWNLOADING)
+                remaining -= len(i)
+                file.write(i)
+                if self._debug:
+                    print(
+                        "Read %d bytes, %d remaining"
+                        % (content_length - remaining, remaining)
+                    )
+                else:
+                    print(".", end="")
+                if not remaining:
+                    break
+                self.neo_status(STATUS_FETCHING)
 
         response.close()
         stamp = time.monotonic() - stamp