Linted #75
Linted #75
Conversation
|
had to disable unspecified-encoding in a few spots. Looked into it a bit, and to be honest I feel like we should get rid of the check org-wide. I've come across it in a few places and every time I came across it I ended up disabling it. |
| f.write("Blinka\nBlackberry Q10 Keyboard") | ||
| f.close() | ||
| with open( # pylint: disable=unspecified-encoding | ||
| "/sd/tft_featherwing.txt", "w" |
There was a problem hiding this comment.
I'm a bit confused here - it was my understanding that the "w" is the encoding. Same for the "r" below. I don't understand why Pylint is throwing this error here.
There was a problem hiding this comment.
Wait no, that's mode. You may be right about disabling org-wide. I'll think on it.
|
I'm also wondering why it's not failing on other libraries that have |
|
@kattni I think they are now. Pretty sure it's just because we changed the pylint version. It's a pretty recent one |
|
I was referring to a few that I merged earlier that were not disabled, but the PR passed. Either way, we're disabling globally at this point. So it's fine. |
|
Sure |
|
@dherrada I'm going to give the contributor on #74 an opportunity to integrate these changes into their PR before merging this one over theirs. Please still remove the disable I mentioned in my last comment, so they have the appropriate set of changes to work with. If they're not interested in integrating into their PR, I'll merge this at that point. |
|
Ah ok |
| f = open("/sd/tft_featherwing.txt", "w") | ||
| f.write("Blinka\nBlackberry Q10 Keyboard") | ||
| f.close() | ||
| with open( # pylint: disable=unspecified-encoding |
|
Closing in favor of #74 |
No description provided.