Add typehints #74
Add typehints #74
Conversation
Change parentheses to brackets, and it should be List[int]
|
Meant to tag this as resolving issue #72 |
I added text to the initial comment so that the issue would be linked. |
|
Missed that, thanks! |
|
I know there was a patch for regarding upgrading pylint, but I can't seem to get it, is that something I should do for this? |
|
@tekktrik You don't need to do anything to upgrade Pylint on this repo, it happens behind the scenes. I've rerun the jobs - a number of the failures are a check we are disabling separately. I will rerun the jobs after that, and then you are welcome to take care of the rest of the linting issues in the repo (as per https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing/pull/75/files) and we can close Dylan's PR in place of this one. Otherwise, I need to merge Dylan's PR, and then you have to update this one to match anyway. Are you up for linting this? You would need to update the imports, and disable |
|
Definitely up for linting! |
|
Just merged that linting branch into mine |
|
Nevermind that, working on it now! |
|
Changes from #75 incorporated! |
| f = open("/sd/tft_featherwing.txt", "w") | ||
| f.write("Blinka\nBlackberry Q10 Keyboard") | ||
| f.close() | ||
| with open( # pylint: disable=unspecified-encoding |
There was a problem hiding this comment.
Please remove this pylint: disable= as we've added it globally. Thanks!
| f = open("/sd/tft_featherwing.txt", "r") | ||
| print(f.read()) | ||
| f.close() | ||
| with open( # pylint: disable=unspecified-encoding |
|
Oh nice catch! Removed! |
|
My pleasure! Thanks for all the assistance on these! |
Shout out to whoever added those Sphinx markups, you made life much easier!
Closes: #72