Skip to content

optional argument to specify not using network #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2022
Merged

optional argument to specify not using network #6

merged 2 commits into from
May 10, 2022

Conversation

FoamyGuy
Copy link
Contributor

This change allows the secrets.py file to be optional with a keyword argument that defaults to True (same behavior as current). While helping someone on discord I noticed that the simpletest script crashes if the user doesn't have a valid secrets.py file, but the example itself doesn't make use of the network.

I think it would be great if people could start playing with the display and other non-network related functionality without having to set up extra things that won't be used yet.

Also modified the simpletest example to use this new argument so that it can run without a secrets.py file. I tested successfully on a Feather S2 TFT on CircuitPython 7.2.5

@ladyada ladyada requested a review from makermelissa April 18, 2022 18:15
@makermelissa
Copy link
Collaborator

The main issue I see with these changes is PortalBase expects Network to be something other than None. That would need to be updated first (see https://github.com/adafruit/Adafruit_CircuitPython_PortalBase/blob/main/adafruit_portalbase/__init__.py).

@FoamyGuy FoamyGuy mentioned this pull request Apr 18, 2022
Merged
@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented May 2, 2022

@makermelissa when you have a chance can you check in on this one now that the change in PortalBase is merged is this good to go?

1 similar comment
@FoamyGuy
Copy link
Contributor Author

FoamyGuy commented May 2, 2022

@makermelissa when you have a chance can you check in on this one now that the change in PortalBase is merged is this good to go?

makermelissa
makermelissa approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't test because I don't have the hardware with me.

makermelissa
makermelissa requested changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, but I noticed the new parameter wasn't added to the docstring.

@FoamyGuy
Copy link
Contributor Author

Thank you. Latest commit adds the docstring.

makermelissa
makermelissa approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@makermelissa makermelissa merged commit 0064a4a into adafruit:main May 10, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 21, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@7998c26)
12fb573 
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.2.0 from 5.1.0:
  > Patch .pre-commit-config.yaml
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#116 from ryanskeith/add_square_wave
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.2.1 from 4.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#163 from dannystaple/patch-1
  > Patch .pre-commit-config.yaml
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#15 from makermelissa/master
  > Patch .pre-commit-config.yaml
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core to 3.2.0 from 3.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_GC_IOT_Core#23 from tannewt/use_real_ntp
  > Patch .pre-commit-config.yaml
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.4 from 2.5.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#43 from tannewt/use_real_ntp
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#45 from adafruit/delete-unused-license
  > Patch .pre-commit-config.yaml

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#9 from sabadam32/add_type_annotations_6
  > Patch .pre-commit-config.yaml
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32S2TFT to 1.1.0 from 1.0.1:
  > Update .pre-commit-config.yaml
  > Patch .pre-commit-config.yaml
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32S2TFT#6 from FoamyGuy/dont_require_secrets_if_no_network
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32S2TFT#5 from FoamyGuy/fix_circup_instructions

Updating https://github.com/adafruit/Adafruit_CircuitPython_OAuth2 to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_OAuth2#7 from ktkinsey37/typing
  > Patch .pre-commit-config.yaml
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.7.3 from 0.7.2:
  > Patch .pre-commit-config.yaml
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#49 from jepler/undo-folder-structure
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#48 from jepler/7seg-counter

Updating https://github.com/adafruit/Adafruit_CircuitPython_Simple_Text_Display to 1.2.4 from 1.2.3:
  > Patch .pre-commit-config.yaml
  > Merge pull request adafruit/Adafruit_CircuitPython_Simple_Text_Display#12 from kattni/docs-fix
  > change discord badge
  > Patch: Replaced discord badge image
  > Updated gitignore
  > Update Black to latest.
  > Fixed readthedocs build
  > Post-patch cleanup
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoamyGuy @makermelissa